[Lldb-commits] [PATCH] D31138: Add stub for PluginProcessNetBSD

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 21 04:53:10 PDT 2017

labath added a comment.

I like the idea of adding boilerplate first, so that we can than better focus on the important stuff later. However, I think you've have gone a bit too far with it -- you introduce a lot of functions I am pretty sure will not be necessary for your case, or that should be handled differently (software single stepping stuff, handling of linux thread stopping, ...).

Could we trim this down to just the functions that are necessary to get this building (basically just virtual overrides -- no private functions or members)? Those can be always added along with the patch that implements them, and then we will be in a better position to review it.



More information about the lldb-commits mailing list