[Lldb-commits] [PATCH] D25832: Minidump plugin: Adding x86_32 register context converter

Adrian McCarthy via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 28 10:51:45 PDT 2016


amccarth accepted this revision.
amccarth added a reviewer: amccarth.
amccarth added inline comments.


================
Comment at: unittests/Process/minidump/MinidumpParserTest.cpp:340
   std::map<uint64_t, uint64_t> reg_values;
 
+  reg_values[lldb_rax_x86_64] = 0x0000000000000000;
----------------
It seems a shame to remove the `// clang-format off` comment for this section.  The aligned version is easier to read.


https://reviews.llvm.org/D25832





More information about the lldb-commits mailing list