[Lldb-commits] [PATCH] D25832: Minidump plugin: Adding x86_32 register context converter

[Dimitar Vlahovski via lldb-commits]

dvlahovski added inline comments.


================
Comment at: unittests/Process/minidump/MinidumpParserTest.cpp:279
 // Register stuff
 // TODO probably split register stuff tests into different file?
+#define REG_VAL32(x) *(reinterpret_cast<uint32_t *>(x))
----------------
labath wrote:
> If you want to split them off to a different file, do it now. If not, remove the todo. (I don't see a reason for the split btw)
Yes, I removed the TODO in my next CL. I'll leave the tests here.


https://reviews.llvm.org/D25832