[Lldb-commits] [PATCH] D24064: Fix lldb build on Mac.
Zachary Turner via lldb-commits
lldb-commits at lists.llvm.org
Tue Aug 30 18:52:22 PDT 2016
Looks good, feel free to commit without review when you're fixing a build
On Tue, Aug 30, 2016 at 4:57 PM Taras Tsugrii <ttsugrii at fb.com> wrote:
> wttsugrii created this revision.
> wttsugrii added a reviewer: zturner.
> wttsugrii added a subscriber: lldb-commits.
>
>
> https://github.com/llvm-mirror/lldb/commit/e80f43fd78fa0fbc04d2d59b5713acb5d06c8308
> greatly improved an API, but missed one more occurence of legacy usage.
>
> This leads to:
> if (extractor.GetHexBytes(&payload_bytes[0], payload_bytes.size(),
> '\xdd') != payload_bytes.size())
> ~~~~~~~~~~~~~~~~~~~~~
> ^~~~~~
> /lldb/include/lldb/Utility/StringExtractor.h:151:5: note: 'GetHexBytes'
> declared here
>
> https://reviews.llvm.org/D24064
>
> Files:
> source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
>
> Index: source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
> ===================================================================
> --- source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
> +++ source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
> @@ -1099,7 +1099,7 @@
> return false;
> }
>
> payload_bytes.resize(ascii_hex_bytes_cstr_len/2);
> - if
> (extractor.GetHexBytes(&payload_bytes[0], payload_bytes.size(), '\xdd') !=
> payload_bytes.size())
> + if (extractor.GetHexBytes(payload_bytes,
> '\xdd') != payload_bytes.size())
> {
> result.AppendErrorWithFormat
> ("payload data must only contain ASCII hex characters (no spaces or hex
> prefixes): '%s'", ascii_hex_bytes_cstr);
> result.SetStatus
> (eReturnStatusFailed);
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160831/8d5b78b1/attachment.html>
More information about the lldb-commits
mailing list