Looks good, feel free to commit without review when you're fixing a build<br><div class="gmail_quote"><div dir="ltr">On Tue, Aug 30, 2016 at 4:57 PM Taras Tsugrii <<a href="mailto:ttsugrii@fb.com">ttsugrii@fb.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">wttsugrii created this revision.<br>
wttsugrii added a reviewer: zturner.<br>
wttsugrii added a subscriber: lldb-commits.<br>
<br>
<a href="https://github.com/llvm-mirror/lldb/commit/e80f43fd78fa0fbc04d2d59b5713acb5d06c8308" rel="noreferrer" target="_blank">https://github.com/llvm-mirror/lldb/commit/e80f43fd78fa0fbc04d2d59b5713acb5d06c8308</a><br>
greatly improved an API, but missed one more occurence of legacy usage.<br>
<br>
This leads to:<br>
if (extractor.GetHexBytes(&payload_bytes[0], payload_bytes.size(), '\xdd') != payload_bytes.size())<br>
~~~~~~~~~~~~~~~~~~~~~ ^~~~~~<br>
/lldb/include/lldb/Utility/StringExtractor.h:151:5: note: 'GetHexBytes' declared here<br>
<br>
<a href="https://reviews.llvm.org/D24064" rel="noreferrer" target="_blank">https://reviews.llvm.org/D24064</a><br>
<br>
Files:<br>
source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp<br>
<br>
Index: source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp<br>
===================================================================<br>
--- source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp<br>
+++ source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp<br>
@@ -1099,7 +1099,7 @@<br>
return false;<br>
}<br>
payload_bytes.resize(ascii_hex_bytes_cstr_len/2);<br>
- if (extractor.GetHexBytes(&payload_bytes[0], payload_bytes.size(), '\xdd') != payload_bytes.size())<br>
+ if (extractor.GetHexBytes(payload_bytes, '\xdd') != payload_bytes.size())<br>
{<br>
result.AppendErrorWithFormat ("payload data must only contain ASCII hex characters (no spaces or hex prefixes): '%s'", ascii_hex_bytes_cstr);<br>
result.SetStatus (eReturnStatusFailed);<br>
<br>
<br>
</blockquote></div>