[Lldb-commits] [PATCH] D24064: Fix lldb build on Mac.

[Taras Tsugrii via lldb-commits]

wttsugrii created this revision.
wttsugrii added a reviewer: zturner.
wttsugrii added a subscriber: lldb-commits.

https://github.com/llvm-mirror/lldb/commit/e80f43fd78fa0fbc04d2d59b5713acb5d06c8308
greatly improved an API, but missed one more occurence of legacy usage.

This leads to:
  if (extractor.GetHexBytes(&payload_bytes[0], payload_bytes.size(), '\xdd') != payload_bytes.size())
                                ~~~~~~~~~~~~~~~~~~~~~                                          ^~~~~~
  /lldb/include/lldb/Utility/StringExtractor.h:151:5: note: 'GetHexBytes' declared here

https://reviews.llvm.org/D24064

Files:
  source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp

Index: source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
===================================================================
--- source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
+++ source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
@@ -1099,7 +1099,7 @@
                                     return false;
                                 }
                                 payload_bytes.resize(ascii_hex_bytes_cstr_len/2);
-                                if (extractor.GetHexBytes(&payload_bytes[0], payload_bytes.size(), '\xdd') != payload_bytes.size())
+                                if (extractor.GetHexBytes(payload_bytes, '\xdd') != payload_bytes.size())
                                 {
                                     result.AppendErrorWithFormat ("payload data must only contain ASCII hex characters (no spaces or hex prefixes): '%s'", ascii_hex_bytes_cstr);
                                     result.SetStatus (eReturnStatusFailed);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24064.69784.patch
Type: text/x-patch
Size: 961 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160830/3b4988b6/attachment.bin>