[Lldb-commits] [PATCH] D22294: Add functionality for rewriting symbols

[Jim Ingham via lldb-commits]

jingham added a comment.

We always resolve duplicate symbols to the "closest" one to the current frame.  So if there are two versions of putchar and one is in the library containing the current frame, we should find that one.  If we aren't getting that right, that's a bug.  So the correct symbol should get called in cases where it makes sense.  But if you are in main, and you have two libraries with rewritten putchar's it isn't clear which one we should call, and I think it isn't all that unexpected that we would just raise an error.  If the duplicate symbols are both exported, but there's other linker magic to pick one over the other in main, then we'd have to know about that to get the right symbol.  But I think that's orthogonal to this discussion.

Jim


http://reviews.llvm.org/D22294