[Lldb-commits] [lldb] r275173 - [test] Fix category-based skipping
Pavel Labath via lldb-commits
lldb-commits at lists.llvm.org
Tue Jul 12 08:07:18 PDT 2016
Author: labath
Date: Tue Jul 12 10:07:18 2016
New Revision: 275173
URL: http://llvm.org/viewvc/llvm-project?rev=275173&view=rev
Log:
[test] Fix category-based skipping
Summary:
LLDBTestResult.hardMarkAsSkipped marked the whole class as skipped when the first class in the
test failed the category check. This meant that subsequent tests in the same class did not run
even if they were passing the category filter. Fix that.
Reviewers: tfiala
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D22213
Modified:
lldb/trunk/packages/Python/lldbsuite/test/test_result.py
Modified: lldb/trunk/packages/Python/lldbsuite/test/test_result.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/test_result.py?rev=275173&r1=275172&r2=275173&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/test_result.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/test_result.py Tue Jul 12 10:07:18 2016
@@ -113,8 +113,6 @@ class LLDBTestResult(unittest2.TextTestR
def hardMarkAsSkipped(self,test):
getattr(test, test._testMethodName).__func__.__unittest_skip__ = True
getattr(test, test._testMethodName).__func__.__unittest_skip_why__ = "test case does not fall in any category of interest for this run"
- test.__class__.__unittest_skip__ = True
- test.__class__.__unittest_skip_why__ = "test case does not fall in any category of interest for this run"
def startTest(self, test):
if configuration.shouldSkipBecauseOfCategories(self.getCategoriesForTest(test)):
More information about the lldb-commits
mailing list