[Lldb-commits] [PATCH] D19520: rL267291: Architecture change to thumb on parsing arm.attributes causes regression.
Muhammad Omair Javaid via lldb-commits
lldb-commits at lists.llvm.org
Tue Apr 26 04:31:49 PDT 2016
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267550: rL267291: Architecture change to thumb on parsing arm.attributes causes… (authored by omjavaid).
Changed prior to commit:
http://reviews.llvm.org/D19520?vs=54961&id=54993#toc
Repository:
rL LLVM
http://reviews.llvm.org/D19520
Files:
lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
Index: lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
===================================================================
--- lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
+++ lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
@@ -1564,19 +1564,6 @@
break;
- case llvm::ARMBuildAttrs::THUMB_ISA_use:
- {
- uint64_t ThumbISA = data.GetULEB128(&Offset);
-
- // NOTE: ignore ThumbISA == llvm::ARMBuildAttrs::AllowThumbDerived
- // since that derives it based on the architecutre/profile
- if (ThumbISA == llvm::ARMBuildAttrs::AllowThumb32)
- if (arch_spec.GetTriple().getArch() == llvm::Triple::UnknownArch ||
- arch_spec.GetTriple().getArch() == llvm::Triple::arm)
- arch_spec.GetTriple().setArch(llvm::Triple::thumb);
-
- break;
- }
case llvm::ARMBuildAttrs::ABI_VFP_args:
{
uint64_t VFPArgs = data.GetULEB128(&Offset);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19520.54993.patch
Type: text/x-patch
Size: 1149 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160426/0838e045/attachment.bin>
More information about the lldb-commits
mailing list