[Lldb-commits] [PATCH] D19520: rL267291: Architecture change to thumb on parsing arm.attributes causes regression.
Tamas Berghammer via lldb-commits
lldb-commits at lists.llvm.org
Tue Apr 26 04:08:25 PDT 2016
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
The change looks good with the explanation but there is a few thing we should do for longer terms:
- Read the value of both Tag_ARM_ISA_use and Tag_THUMB_ISA_use and set the architecture based on the 2 value (set it to thumb only is Tag_ARM_ISA_use=0 and Tag_THUMB_ISA_use=2)
- Fix LLDB to work when the triple is "thumb-*-*-*" as currently we have several location where we don't handle this case even if the full executable contains thumb code only (e.g. Platform::GetSoftwareBreakpointTrapOpcode)
More information about the lldb-commits