[Lldb-commits] [lldb] r267550 - rL267291: Architecture change to thumb on parsing arm.attributes causes regression.

Omair Javaid via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 26 04:26:01 PDT 2016


Author: omjavaid
Date: Tue Apr 26 06:26:00 2016
New Revision: 267550

URL: http://llvm.org/viewvc/llvm-project?rev=267550&view=rev
Log:
rL267291: Architecture change to thumb on parsing arm.attributes causes regression.

Remove case handling elf arm attribute Tag_THUMB_ISA_use and setting architecture to thumb. 

Differential revision: http://reviews.llvm.org/D19520


Modified:
    lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

Modified: lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp?rev=267550&r1=267549&r2=267550&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp (original)
+++ lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp Tue Apr 26 06:26:00 2016
@@ -1564,19 +1564,6 @@ ObjectFileELF::ParseARMAttributes(DataEx
 
                     break;
 
-                case llvm::ARMBuildAttrs::THUMB_ISA_use:
-                {
-                    uint64_t ThumbISA = data.GetULEB128(&Offset);
-
-                    // NOTE: ignore ThumbISA == llvm::ARMBuildAttrs::AllowThumbDerived
-                    // since that derives it based on the architecutre/profile
-                    if (ThumbISA == llvm::ARMBuildAttrs::AllowThumb32)
-                        if (arch_spec.GetTriple().getArch() == llvm::Triple::UnknownArch ||
-                            arch_spec.GetTriple().getArch() == llvm::Triple::arm)
-                            arch_spec.GetTriple().setArch(llvm::Triple::thumb);
-
-                    break;
-                }
                 case llvm::ARMBuildAttrs::ABI_VFP_args:
                 {
                     uint64_t VFPArgs = data.GetULEB128(&Offset);




More information about the lldb-commits mailing list