[Lldb-commits] [PATCH] D17616: Add a set of new plugins to handle Java debugging

[Enrico Granata via lldb-commits]

granata.enrico added a subscriber: granata.enrico.

================
Comment at: source/Plugins/Language/Java/JavaLanguage.cpp:81
@@ +80,3 @@
+HardcodedFormatters::HardcodedSummaryFinder
+JavaLanguage::GetHardcodedSummaries()
+{
----------------
Is there any reason to use hardcoded summaries here?

It looks like IsJavaString is a trivial textual match on the string "java.lang.String". If so, could you please avoid hardcoding this formatter?

The rationale is that an hardcoded formatter can never be turned off by the user, whereas for a normal typename --> formatter match, the user has a way to delete the individual formatter should they desire to do so.

Not a big deal, but would be great to fix if possible.


http://reviews.llvm.org/D17616