[Lldb-commits] [PATCH] D17616: Add a set of new plugins to handle Java debugging

[Oleksiy Vyalov via lldb-commits]

ovyalov accepted this revision.

================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserJava.cpp:35
@@ +34,3 @@
+lldb::TypeSP
+DWARFASTParserJava::ParseTypeFromDWARF(const lldb_private::SymbolContext &sc, const DWARFDIE &die,
+                                       lldb_private::Log *log, bool *type_is_new_ptr)
----------------
Please consider splitting this method in smaller sub-methods.

================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserJava.cpp:519
@@ +518,1 @@
+}
\ No newline at end of file

----------------
Please fix.


http://reviews.llvm.org/D17616