[Lldb-commits] [PATCH] D17616: Add a set of new plugins to handle Java debugging

[Tamas Berghammer via lldb-commits]

tberghammer marked 2 inline comments as done.

================
Comment at: source/Plugins/Language/Java/JavaLanguage.cpp:81
@@ +80,3 @@
+HardcodedFormatters::HardcodedSummaryFinder
+JavaLanguage::GetHardcodedSummaries()
+{
----------------
granata.enrico wrote:
> Is there any reason to use hardcoded summaries here?
> 
> It looks like IsJavaString is a trivial textual match on the string "java.lang.String". If so, could you please avoid hardcoding this formatter?
> 
> The rationale is that an hardcoded formatter can never be turned off by the user, whereas for a normal typename --> formatter match, the user has a way to delete the individual formatter should they desire to do so.
> 
> Not a big deal, but would be great to fix if possible.
I don't think this is a formatter a user will ever turn off because without it there is no sensible way to display the content of the string (traversing into a member won't work because we don't have a "const char*" member) but I updated it anyway to be a normal type name based formatter based on your suggestion.

================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserJava.cpp:35
@@ +34,3 @@
+lldb::TypeSP
+DWARFASTParserJava::ParseTypeFromDWARF(const lldb_private::SymbolContext &sc, const DWARFDIE &die,
+                                       lldb_private::Log *log, bool *type_is_new_ptr)
----------------
ovyalov wrote:
> Please consider splitting this method in smaller sub-methods.
Done

================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserJava.cpp:519
@@ +518,1 @@
+}
\ No newline at end of file

----------------
ovyalov wrote:
> Please fix.
Done


http://reviews.llvm.org/D17616