[Lldb-commits] [PATCH] D17088: Add target and host platform enums so we're not using strings everywhere

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 11 08:03:49 PST 2016


zturner added a comment.

I think technically there are some platforms that cannot be both a host and a target.  ios and anything involving a simulator comes to mind.  But, if the only "gotcha" to having both of them be in the same enum is that it's up to the programmer to make sure he's using the right value in the context, then perhaps it's not the end of the world.

BTW, there were some things I wasn't sure whether to add to the enum here.  `android`, `remote_android`, `ios-simulator`, etc.  Should I add them, or should I leave it as is for now and let other people fix up their own platforms?


http://reviews.llvm.org/D17088





More information about the lldb-commits mailing list