[Lldb-commits] [PATCH] D17088: Add target and host platform enums so we're not using strings everywhere

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 11 08:36:24 PST 2016

labath added a comment.

In http://reviews.llvm.org/D17088#350005, @zturner wrote:

> I think technically there are some platforms that cannot be both a host and a target.  ios and anything involving a simulator comes to mind.  But, if the only "gotcha" to having both of them be in the same enum is that it's up to the programmer to make sure he's using the right value in the context, then perhaps it's not the end of the world.

Although unlikely, I don't think there is an inherent reason lldb could not run there, so yeah, I think one list is better.

> BTW, there were some things I wasn't sure whether to add to the enum here.  `android`, `remote_android`, `ios-simulator`, etc.  Should I add them, or should I leave it as is for now and let other people fix up their own platforms?

I think we should let people add targets when they need to, so let's leave these out for now. As I said, right now we treat android as a flavour of linux. When we change that we can add `android` and `linux_all` (or something like that) to the list.


More information about the lldb-commits mailing list