[Lldb-commits] [PATCH] D17088: Add target and host platform enums so we're not using strings everywhere

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 11 01:22:42 PST 2016

labath added a comment.

I like the idea. I think this could help us with the linux vs. android dilemma we've been having recently: currently, we consider android to be a flavour of linux, which means it's not possible to XFAIL tests passing on android but failing on linux. This should make expressing something like that easier.

I wonder, however, whether you need separate enums for `host` and `target`. I mean, any system can be used as one or the other, right? (Granted, nobody has tried bringing up lldb client on e.g., android, but I actually don't expect it would be so hard, and I don't see a reason to not support it here). What would you say to merging the two enums and calling it simply `os`, `platform` or something?


More information about the lldb-commits mailing list