[Lldb-commits] [PATCH] D16840: [LLDB][MIPS] Generalise MIPS arch names

[Zachary Turner via lldb-commits]

Looks fine to me

On Tue, Feb 2, 2016 at 11:57 PM Nitesh Jain <nitesh.jain at imgtec.com> wrote:

> nitesh.jain updated this revision to Diff 46750.
> nitesh.jain added a comment.
>
> Update the diff with suggested changes
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D16840
>
> Files:
>
> packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py
>
> packages/Python/lldbsuite/test/functionalities/watchpoint/hello_watchlocation/TestWatchLocation.py
>
> packages/Python/lldbsuite/test/functionalities/watchpoint/step_over_watchpoint/TestStepOverWatchpoint.py
>
> Index:
> packages/Python/lldbsuite/test/functionalities/watchpoint/step_over_watchpoint/TestStepOverWatchpoint.py
> ===================================================================
> ---
> packages/Python/lldbsuite/test/functionalities/watchpoint/step_over_watchpoint/TestStepOverWatchpoint.py
> +++
> packages/Python/lldbsuite/test/functionalities/watchpoint/step_over_watchpoint/TestStepOverWatchpoint.py
> @@ -73,7 +73,7 @@
>
>          # Most of the MIPS boards provide only one H/W watchpoints, and
> S/W watchpoints are not supported yet
>          arch = self.getArchitecture()
> -        if arch in ['mips', 'mipsel', 'mips64', 'mips64el']:
> +        if re.match("mips",arch):
>              self.runCmd("watchpoint delete 1")
>
>          # resolve_location=True, read=False, write=True
> Index:
> packages/Python/lldbsuite/test/functionalities/watchpoint/hello_watchlocation/TestWatchLocation.py
> ===================================================================
> ---
> packages/Python/lldbsuite/test/functionalities/watchpoint/hello_watchlocation/TestWatchLocation.py
> +++
> packages/Python/lldbsuite/test/functionalities/watchpoint/hello_watchlocation/TestWatchLocation.py
> @@ -31,7 +31,7 @@
>
>      @expectedFailureAndroid(archs=['arm', 'aarch64']) # Watchpoints not
> supported
>      @expectedFailureWindows("llvm.org/pr24446") # WINDOWS XFAIL TRIAGE -
> Watchpoints not supported on Windows
> -    @expectedFailureAll(archs=['mips', 'mipsel', 'mips64', 'mips64el']) #
> Most of the MIPS boards provide only one H/W watchpoints, and S/W
> watchpoints are not supported yet
> +    @expectedFailureAll(triple = 'mips') # Most of the MIPS boards
> provide only one H/W watchpoints, and S/W watchpoints are not supported yet
>      def test_hello_watchlocation(self):
>          """Test watching a location with '-s size' option."""
>          self.build(dictionary=self.d)
> Index:
> packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py
> ===================================================================
> ---
> packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py
> +++
> packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py
> @@ -21,7 +21,7 @@
>
>      @expectedFailureWindows("llvm.org/pr24778")
>      @expectedFailureAndroid("llvm.org/pr24497", archs=['arm', 'aarch64'])
> -    @expectedFailureAll(archs=['mips', 'mipsel', 'mips64', 'mips64el'])
>   # IO error due to breakpoint at invalid address
> +    @expectedFailureAll(triple = 'mips')    # IO error due to breakpoint
> at invalid address
>      def test_step_inst_with(self):
>          """Test thread creation during step-inst handling."""
>          self.build(dictionary=self.getBuildFlags())
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160203/81871511/attachment.html>