[Lldb-commits] [PATCH] D16840: [LLDB][MIPS] Generalise MIPS arch names

[Greg Clayton via lldb-commits]

clayborg accepted this revision.
clayborg added a comment.

I believe we recently switched "archs" so that we auto detect the type so you could use a regular expression. See above inlined comments.

Good to go unless you want to adopt any of my inlined suggestions.


================
Comment at: packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py:24
@@ -23,3 +23,3 @@
     @expectedFailureAndroid("llvm.org/pr24497", archs=['arm', 'aarch64'])
-    @expectedFailureAll(archs=['mips', 'mipsel', 'mips64', 'mips64el'])    # IO error due to breakpoint at invalid address
+    @expectedFailureAll(triple = 'mips')    # IO error due to breakpoint at invalid address
     def test_step_inst_with(self):
----------------
You can use archs in this case if you want to by assigning it to a compiled regular expression:

```
@expectedFailureAll(archs=re.compile('^mips'))    # IO error due to breakpoint at invalid address
```

================
Comment at: packages/Python/lldbsuite/test/functionalities/watchpoint/hello_watchlocation/TestWatchLocation.py:34
@@ -33,3 +33,3 @@
     @expectedFailureWindows("llvm.org/pr24446") # WINDOWS XFAIL TRIAGE - Watchpoints not supported on Windows
-    @expectedFailureAll(archs=['mips', 'mipsel', 'mips64', 'mips64el']) # Most of the MIPS boards provide only one H/W watchpoints, and S/W watchpoints are not supported yet
+    @expectedFailureAll(triple = 'mips') # Most of the MIPS boards provide only one H/W watchpoints, and S/W watchpoints are not supported yet
     def test_hello_watchlocation(self):
----------------
Could use:

```
@expectedFailureAll(archs=re.compile('^mips'))
```

================
Comment at: packages/Python/lldbsuite/test/functionalities/watchpoint/step_over_watchpoint/TestStepOverWatchpoint.py:76
@@ -75,3 +75,3 @@
         arch = self.getArchitecture()
-        if arch in ['mips', 'mipsel', 'mips64', 'mips64el']:
+        if re.match("mips",arch):
             self.runCmd("watchpoint delete 1")
----------------
should this be:

```
if re.match("^mips",arch):
```


Repository:
  rL LLVM

http://reviews.llvm.org/D16840