<div dir="ltr">Looks fine to me</div><br><div class="gmail_quote"><div dir="ltr">On Tue, Feb 2, 2016 at 11:57 PM Nitesh Jain <<a href="mailto:nitesh.jain@imgtec.com">nitesh.jain@imgtec.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">nitesh.jain updated this revision to Diff 46750.<br>
nitesh.jain added a comment.<br>
<br>
Update the diff with suggested changes<br>
<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="http://reviews.llvm.org/D16840" rel="noreferrer" target="_blank">http://reviews.llvm.org/D16840</a><br>
<br>
Files:<br>
  packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py<br>
  packages/Python/lldbsuite/test/functionalities/watchpoint/hello_watchlocation/TestWatchLocation.py<br>
  packages/Python/lldbsuite/test/functionalities/watchpoint/step_over_watchpoint/TestStepOverWatchpoint.py<br>
<br>
Index: packages/Python/lldbsuite/test/functionalities/watchpoint/step_over_watchpoint/TestStepOverWatchpoint.py<br>
===================================================================<br>
--- packages/Python/lldbsuite/test/functionalities/watchpoint/step_over_watchpoint/TestStepOverWatchpoint.py<br>
+++ packages/Python/lldbsuite/test/functionalities/watchpoint/step_over_watchpoint/TestStepOverWatchpoint.py<br>
@@ -73,7 +73,7 @@<br>
<br>
         # Most of the MIPS boards provide only one H/W watchpoints, and S/W watchpoints are not supported yet<br>
         arch = self.getArchitecture()<br>
-        if arch in ['mips', 'mipsel', 'mips64', 'mips64el']:<br>
+        if re.match("mips",arch):<br>
             self.runCmd("watchpoint delete 1")<br>
<br>
         # resolve_location=True, read=False, write=True<br>
Index: packages/Python/lldbsuite/test/functionalities/watchpoint/hello_watchlocation/TestWatchLocation.py<br>
===================================================================<br>
--- packages/Python/lldbsuite/test/functionalities/watchpoint/hello_watchlocation/TestWatchLocation.py<br>
+++ packages/Python/lldbsuite/test/functionalities/watchpoint/hello_watchlocation/TestWatchLocation.py<br>
@@ -31,7 +31,7 @@<br>
<br>
     @expectedFailureAndroid(archs=['arm', 'aarch64']) # Watchpoints not supported<br>
     @expectedFailureWindows("<a href="http://llvm.org/pr24446" rel="noreferrer" target="_blank">llvm.org/pr24446</a>") # WINDOWS XFAIL TRIAGE - Watchpoints not supported on Windows<br>
-    @expectedFailureAll(archs=['mips', 'mipsel', 'mips64', 'mips64el']) # Most of the MIPS boards provide only one H/W watchpoints, and S/W watchpoints are not supported yet<br>
+    @expectedFailureAll(triple = 'mips') # Most of the MIPS boards provide only one H/W watchpoints, and S/W watchpoints are not supported yet<br>
     def test_hello_watchlocation(self):<br>
         """Test watching a location with '-s size' option."""<br>
         self.build(dictionary=self.d)<br>
Index: packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py<br>
===================================================================<br>
--- packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py<br>
+++ packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py<br>
@@ -21,7 +21,7 @@<br>
<br>
     @expectedFailureWindows("<a href="http://llvm.org/pr24778" rel="noreferrer" target="_blank">llvm.org/pr24778</a>")<br>
     @expectedFailureAndroid("<a href="http://llvm.org/pr24497" rel="noreferrer" target="_blank">llvm.org/pr24497</a>", archs=['arm', 'aarch64'])<br>
-    @expectedFailureAll(archs=['mips', 'mipsel', 'mips64', 'mips64el'])    # IO error due to breakpoint at invalid address<br>
+    @expectedFailureAll(triple = 'mips')    # IO error due to breakpoint at invalid address<br>
     def test_step_inst_with(self):<br>
         """Test thread creation during step-inst handling."""<br>
         self.build(dictionary=self.getBuildFlags())<br>
<br>
<br>
</blockquote></div>