[Lldb-commits] [PATCH] D13296: [LLDB] Fix watchpoint ignore feature for architectures with watchpoint_exceptions_received=before

[Jim Ingham via lldb-commits]

The substance is fine.  I fixed up the grammar a little, maybe something like:

TODO: This condition should be checked in the synchronous part of the watchpoint code (Watchpoint::ShouldStop), so that 
we avoid pulling an event even if the watchpoint fails the ignore count condition. It is moved here temporarily, because for
archs with watchpoint_exceptions_received=before, the code in the previous lines takes care of moving the inferior to next PC. 
We have to check the ignore count condition after this is done, otherwise we will hit same watchpoint 
multiple times until we pass ignore condition, but we won't actually be ignoring them.

Jim

> On Oct 30, 2015, at 4:54 AM, Mohit Bhakkad <mohit.bhakkad at gmail.com> wrote:
> 
> mohit.bhakkad added a comment.
> 
> I forgot about note part, is it okay to add a TODO before ignore count condition in source/Target/StopInfo.cpp:
> 
> TODO: This condition should be checked in synchronous part of watchpoint code (Watchpoint::ShouldStop), so that 
> we avoid pulling an event even if watchpoint fails ignore count condition. It is moved here temporarily, because for
> archs with watchpoint_exceptions_received=before, there is an adjustment code in above lines, which takes control 
> of inferior to next PC. We have to check ignore count condition after this is done, otherwise we will get same watchpoint 
> multiple  times untill we pass ignore condition, and we won't be ignoring them actually.
> 
> 
> Repository:
>  rL LLVM
> 
> http://reviews.llvm.org/D13296
> 
> 
>