[Lldb-commits] [PATCH] D13296: [LLDB] Fix watchpoint ignore feature for architectures with watchpoint_exceptions_received=before
Mohit Bhakkad via lldb-commits
lldb-commits at lists.llvm.org
Fri Oct 30 04:54:41 PDT 2015
mohit.bhakkad added a comment.
I forgot about note part, is it okay to add a TODO before ignore count condition in source/Target/StopInfo.cpp:
TODO: This condition should be checked in synchronous part of watchpoint code (Watchpoint::ShouldStop), so that
we avoid pulling an event even if watchpoint fails ignore count condition. It is moved here temporarily, because for
archs with watchpoint_exceptions_received=before, there is an adjustment code in above lines, which takes control
of inferior to next PC. We have to check ignore count condition after this is done, otherwise we will get same watchpoint
multiple times untill we pass ignore condition, and we won't be ignoring them actually.
More information about the lldb-commits