[Lldb-commits] [PATCH] D13296: [LLDB] Fix watchpoint ignore feature for architectures with watchpoint_exceptions_received=before

Jim Ingham via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 30 10:34:15 PDT 2015

jingham added a subscriber: jingham.
jingham added a comment.

The substance is fine.  I fixed up the grammar a little, maybe something like:

TODO: This condition should be checked in the synchronous part of the watchpoint code (Watchpoint::ShouldStop), so that 
we avoid pulling an event even if the watchpoint fails the ignore count condition. It is moved here temporarily, because for
archs with watchpoint_exceptions_received=before, the code in the previous lines takes care of moving the inferior to next PC. 
We have to check the ignore count condition after this is done, otherwise we will hit same watchpoint 
multiple times until we pass ignore condition, but we won't actually be ignoring them.




More information about the lldb-commits mailing list