[Lldb-commits] [PATCH] D13296: [LLDB] Fix watchpoint ignore feature for architectures with watchpoint_exceptions_received=before

Mohit Bhakkad via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 30 04:20:37 PDT 2015


mohit.bhakkad requested a review of this revision.
mohit.bhakkad added a comment.



> Note, if you end up going with the current patch, isn't quite right, however.  You need to move the check for the watchpoint ignore count up before printing out the old & new values.  An ignored watchpoint shouldn't print anything, it should be as if it never stopped.  Where you have the check, the old & new values will get printed even if the watchpoint is ignored.


Hi @jingham, I re-checked it today, we are not printing anything when we ignore a watchpoint.


Repository:
  rL LLVM

http://reviews.llvm.org/D13296





More information about the lldb-commits mailing list