[Lldb-commits] [PATCH] D12115: [LLDB-MI] Fix -data-info-line and -symbol-list-lines when Windows filenames are used.

Dawn Perchik via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 10 17:03:56 PDT 2015


dawn added a comment.

In http://reviews.llvm.org/D12115#243093, @abidh wrote:

> We dont use the lldb_private stuff inside lldb-mi. Please see the discussion in the following thread.
>  http://lists.llvm.org/pipermail/lldb-dev/2015-March/007047.html


Thank you for your review and for the link.  I agree in general and have avoided lldb_private myself, but this means duplicated code which is arguably worse.  I think it's time to make lldb-mi a proper part of lldb to avoid reinventing the wheel, or adding SB APIs that make no sense outside of lldb-mi.  But I am sympathetic to both arguments so will revise.


Repository:
  rL LLVM

http://reviews.llvm.org/D12115





More information about the lldb-commits mailing list