[Lldb-commits] [PATCH] D12677: Bug 24733: TestRegisters.py for Clang inferiors

[Oleksiy Vyalov via lldb-commits]

ovyalov added a comment.

In http://reviews.llvm.org/D12677#242290, @abhishek.aggarwal wrote:

> In http://reviews.llvm.org/D12677#242006, @ovyalov wrote:
>
> > I reverted the CL because it was causing TestRegisters.test_fp_special_purpose_register_read to fail on OSX:
> >
> > - stop reason = EXC_BREAKPOINT
> > - "register read ftag" yields 0x80 instead of expected 0x8000
>
>
>


Hi Abhishek,

please see my comments inline:

> Hi Oleksiy

> 

> Thanks for pointing out.  Two things:

> 

> 1. Is it possible for you to share the failure log for this test on MacOSX? The expected value of ftag is 0x0080 and not 0x8000. Which compiler was used to compile inferior?


F818989: TestRegisters.txt <http://reviews.llvm.org/F818989>

I'm using clang 3.6

> 2. Do you think that this patch needs reversion? In my opinion, this patch provides a much better (genric) way to test X87 FPU on Linux OS (atleast). I don't know whether the status for MacOSX would have even changed after you reverted this patch. I believe, it should still fail for MacOSX. I can take a look for MacOSX once you provide me failure logs. I would recommend to keep this patch and for the time being skip it for MacOSX. Once I find a fix for it on MacOSX, we can enable it for the same as well. What do you think ?


It makes sense to me to split fix in a few iterations:

1. Submit the patch as-is just with XFAIL for Darwin (please check whether llvm.org/pr24733 is still relevant or it's failing on OSX due another error).
2. Make a fix for Darwin if possible.


http://reviews.llvm.org/D12677