[Lldb-commits] [PATCH] D12683: Fix debugger shutdown when Python interpreter is loaded

Todd Fiala via lldb-commits lldb-commits at lists.llvm.org
Mon Sep 7 22:46:18 PDT 2015


tfiala added inline comments.

================
Comment at: source/Core/Debugger.cpp:426
@@ +425,3 @@
+    for (const auto& debugger: debuggers)
+        debugger->Clear();
+
----------------
ovyalov wrote:
> tfiala wrote:
> > Wouldn't Clear() be considered a mutating function?  So a const debugger ref seems like maybe it should be non-const?
> > 
> > i.e.
> > for (auto& debugger: debuggers) {
> >      debugger->Clear();
> > }
> > 
> Clear is mutable, but debugger has DebuggerSP type here - so, const is applicable only to shared_ptr, not to Debugger instance itself.
Ah gotcha.


http://reviews.llvm.org/D12683





More information about the lldb-commits mailing list