[Lldb-commits] [PATCH] D12683: Fix debugger shutdown when Python interpreter is loaded

Oleksiy Vyalov via lldb-commits lldb-commits at lists.llvm.org
Mon Sep 7 22:27:36 PDT 2015

ovyalov added inline comments.

Comment at: source/Core/Debugger.cpp:426
@@ +425,3 @@
+    for (const auto& debugger: debuggers)
+        debugger->Clear();
tfiala wrote:
> Wouldn't Clear() be considered a mutating function?  So a const debugger ref seems like maybe it should be non-const?
> i.e.
> for (auto& debugger: debuggers) {
>      debugger->Clear();
> }
Clear is mutable, but debugger has DebuggerSP type here - so, const is applicable only to shared_ptr, not to Debugger instance itself.


More information about the lldb-commits mailing list