[Lldb-commits] [lldb] r245547 - [LLDB] Use llvm::APInt and llvm::APFloat in Scalar and RegisterValue

[Hans Wennborg via lldb-commits]

I'm not happy about this.

lldb builds fine on Linux for me. What's the build problem on mips? I
also don't see the relation between r245240 (which was also a large
patch) and this, but I haven't looked closely and am not familiar with
the code.

In general it would be nice if merge requests don't break the build. I
do check that the build works on x86_64 Linux before committing a
merge, but I don't have a mips machine.

RC3 was just tagged and will be the final release unless a critical
regression comes up.

If you need a build fix or revert for MIPS I'd be willing to squeeze
that in if we do an RC4 for some other reason, or before committing
the -final tag (but then it really has to be a mips-only change that
would not affect other platforms).


Thanks,
Hans

On Fri, Aug 21, 2015 at 3:17 AM,  <Sagar.Thakur at imgtec.com> wrote:
> Hi Tamas,
>
> The code in release branch will fail to compile on mips if we don’t merge
> this change because the commit r245240 in the release branch is dependant on
> this change.  If we don't want to merge this change to the release branch
> then we will have to revert r245240 from the release branch so that the code
> from release branch can compile properly.
>
> Thanks,
> Sagar
>
>
> On Friday 21 August 2015 03:06 PM, Tamas Berghammer wrote:
>
> Hi Sagar,
>
> I don't really happy with merging a big change to the release branch at the
> last moment (after RC3) especially as this commit caused several issues in
> the past and I don't think we tested it extensively enough to be sure it is
> works as intended at the moment.
>
> Is there any reason you really want this change in LLDB 3.7 considering that
> we won't create a binary with the release as far as I know?
>
> Thanks,
> Tamas
>
> On Fri, Aug 21, 2015 at 10:20 AM via lldb-commits
> <lldb-commits at lists.llvm.org> wrote:
>>
>> Hi Hans,
>>
>> Could you please merge r245547 to the release branch ?
>>
>> Thanks,
>> Sagar
>>
>> On Thursday 20 August 2015 02:42 PM, Sagar Thakur via lldb-commits wrote:
>> > Author: slthakur
>> > Date: Thu Aug 20 04:12:46 2015
>> > New Revision: 245547
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=245547&view=rev
>> > Log:
>> > [LLDB] Use llvm::APInt and llvm::APFloat in Scalar and RegisterValue
>> >
>> > Eliminated ENABLE_128_BIT_SUPPORT and union ValueData from Scalar.cpp
>> > and use llvm::APInt and llvm::APFloat for all integer and floating point
>> > types. Also used Scalar in RegisterValue.cpp
>> >
>> > Reviewers: tberghammer, ovyalov, clayborg, labath
>> > Subscribers: lldb-commits, nitesh.jain, jaydeep
>> > Differential: http://reviews.llvm.org/D12100