[Lldb-commits] [PATCH] D12187: [NativeProcessLinux] Reduce the number of casts

Tamas Berghammer via lldb-commits lldb-commits at lists.llvm.org
Thu Aug 20 04:05:58 PDT 2015

tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.

Looks good.

One inconsistency what might worth a change is that you usually pass NPL as a shared_ptr (or a reference to a shared_ptr) but you created a few function where it isn't true (e.g. ThreadWasCreated). I would prefer to always pass it by shared_ptr (possibly as a reference) for consistency.


More information about the lldb-commits mailing list