[Lldb-commits] [PATCH] D12100: [LLDB] Use llvm::APInt and llvm::APFloat in Scalar and RegisterValue

[Sagar Thakur via lldb-commits]

sagar added inline comments.

================
Comment at: include/lldb/Core/RegisterValue.h:185
@@ -190,1 +184,3 @@
+        llvm::APInt
+        GetAsUInt128 (llvm::APInt& fail_value, bool *success_ptr = NULL) const;
 
----------------
ovyalov wrote:
> Could you pass fail_value as a const reference?
Yes, I have changed fail_value to const reference.


Repository:
  rL LLVM

http://reviews.llvm.org/D12100