[Lldb-commits] [PATCH] D11543: Fix evaluation of global operators in C++

Chaoren Lin via lldb-commits lldb-commits at lists.llvm.org
Tue Aug 18 21:27:14 PDT 2015


chaoren added a subscriber: chaoren.

================
Comment at: test/lang/cpp/global_operators/TestCppGlobalOperators.py:9
@@ +8,3 @@
+class TestCppGlobalOperators(TestBase):
+    
+    mydir = TestBase.compute_mydir(__file__)
----------------
Please be careful of trailing whitespaces.

================
Comment at: test/lang/cpp/global_operators/TestCppGlobalOperators.py:48
@@ +47,3 @@
+        env = None
+        process = target.LaunchSimple(args, env, cwd)
+        self.assertTrue(process.IsValid(), PROCESS_IS_VALID)
----------------
Please use `self.get_process_working_directory()` instead of `cwd`, so that this works for remote targets.


http://reviews.llvm.org/D11543





More information about the lldb-commits mailing list