[Lldb-commits] [lldb] r245338 - [Windows] XFAIL tests that depend on expression name lookup.

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Tue Aug 18 13:01:29 PDT 2015


Author: zturner
Date: Tue Aug 18 15:01:28 2015
New Revision: 245338

URL: http://llvm.org/viewvc/llvm-project?rev=245338&view=rev
Log:
[Windows] XFAIL tests that depend on expression name lookup.

Name lookup doesn't work properly with Windows targets.  This is
most likely due to issues with name mangling, although there is at
least one set of debug info related issues as well, since some of
the name lookup requests appear to be failing on types rather than
symbols.

Specifically, this patch XFAILS the following set of tests:

TestChar1632T.py
TestRdar12991846.py
TestConstVariables.py
TestCallCPPFunction.py
TestCallStopAndContinue.py
TestCallUserDefinedFunction.py
TestCModules.py
TestCPPThis.py
TestExprs2.py
TestOverloadedFunctions.py
TestRvalueReferences.py

And fixing the underlying issue is tracked in http://llvm.org/pr24489

Modified:
    lldb/trunk/test/expression_command/call-function/TestCallStopAndContinue.py
    lldb/trunk/test/expression_command/call-function/TestCallUserDefinedFunction.py
    lldb/trunk/test/expression_command/test/TestExprs2.py
    lldb/trunk/test/lang/c/const_variables/TestConstVariables.py
    lldb/trunk/test/lang/c/modules/TestCModules.py
    lldb/trunk/test/lang/cpp/call-function/TestCallCPPFunction.py
    lldb/trunk/test/lang/cpp/char1632_t/TestChar1632T.py
    lldb/trunk/test/lang/cpp/overloaded-functions/TestOverloadedFunctions.py
    lldb/trunk/test/lang/cpp/rdar12991846/TestRdar12991846.py
    lldb/trunk/test/lang/cpp/rvalue-references/TestRvalueReferences.py
    lldb/trunk/test/lang/cpp/this/TestCPPThis.py

Modified: lldb/trunk/test/expression_command/call-function/TestCallStopAndContinue.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/expression_command/call-function/TestCallStopAndContinue.py?rev=245338&r1=245337&r2=245338&view=diff
==============================================================================
--- lldb/trunk/test/expression_command/call-function/TestCallStopAndContinue.py (original)
+++ lldb/trunk/test/expression_command/call-function/TestCallStopAndContinue.py Tue Aug 18 15:01:28 2015
@@ -30,6 +30,7 @@ class ExprCommandCallStopContinueTestCas
 
     @dwarf_test
     @expectedFlakeyDarwin("llvm.org/pr20274")
+    @expectedFailureWindows("llvm.org/pr24489: Name lookup not working correctly on Windows")
     def test_with_dwarf(self):
         """Test gathering result from interrupted function call."""
         self.buildDwarf()

Modified: lldb/trunk/test/expression_command/call-function/TestCallUserDefinedFunction.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/expression_command/call-function/TestCallUserDefinedFunction.py?rev=245338&r1=245337&r2=245338&view=diff
==============================================================================
--- lldb/trunk/test/expression_command/call-function/TestCallUserDefinedFunction.py (original)
+++ lldb/trunk/test/expression_command/call-function/TestCallUserDefinedFunction.py Tue Aug 18 15:01:28 2015
@@ -31,6 +31,7 @@ class ExprCommandCallUserDefinedFunction
         self.call_function()
 
     @dwarf_test
+    @expectedFailureWindows("llvm.org/pr24489: Name lookup not working correctly on Windows")
     @expectedFailureFreeBSD("llvm.org/pr20274") # intermittent failure
     def test_with_dwarf(self):
         """Test return values of user defined function calls."""

Modified: lldb/trunk/test/expression_command/test/TestExprs2.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/expression_command/test/TestExprs2.py?rev=245338&r1=245337&r2=245338&view=diff
==============================================================================
--- lldb/trunk/test/expression_command/test/TestExprs2.py (original)
+++ lldb/trunk/test/expression_command/test/TestExprs2.py Tue Aug 18 15:01:28 2015
@@ -19,6 +19,7 @@ class ExprCommands2TestCase(TestBase):
         self.line = line_number('main.cpp',
                                 '// Please test many expressions while stopped at this line:')
 
+    @expectedFailureWindows("llvm.org/pr24489: Name lookup not working correctly on Windows")
     def test_more_expr_commands(self):
         """Test some more expression commands."""
         self.buildDefault()

Modified: lldb/trunk/test/lang/c/const_variables/TestConstVariables.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/lang/c/const_variables/TestConstVariables.py?rev=245338&r1=245337&r2=245338&view=diff
==============================================================================
--- lldb/trunk/test/lang/c/const_variables/TestConstVariables.py (original)
+++ lldb/trunk/test/lang/c/const_variables/TestConstVariables.py Tue Aug 18 15:01:28 2015
@@ -18,6 +18,8 @@ class ConstVariableTestCase(TestBase):
         self.const_variable()
 
     @expectedFailureClang('13314878') # This test works with gcc, but fails with newer version of clang on Linux due to a clang issue. Fails for icc as well. Bug number TDB.
+    @expectedFailureWindows("llvm.org/pr24489: Name lookup not working correctly on Windows")
+    @expectedFailureWindows("llvm.org/pr24490: We shouldn't be using platform-specific names like `getpid` in tests")
     @dwarf_test
     def test_with_dwarf_and_run_command(self):
         """Test interpreted and JITted expressions on constant values."""

Modified: lldb/trunk/test/lang/c/modules/TestCModules.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/lang/c/modules/TestCModules.py?rev=245338&r1=245337&r2=245338&view=diff
==============================================================================
--- lldb/trunk/test/lang/c/modules/TestCModules.py (original)
+++ lldb/trunk/test/lang/c/modules/TestCModules.py Tue Aug 18 15:01:28 2015
@@ -23,6 +23,7 @@ class CModulesTestCase(TestBase):
     @dwarf_test
     @skipIfFreeBSD
     @expectedFailureLinux('http://llvm.org/pr23456') # 'fopen' has unknown return type
+    @expectedFailureWindows("llvm.org/pr24489: Name lookup not working correctly on Windows")
     def test_expr_with_dwarf(self):
         self.buildDwarf()
         self.expr()

Modified: lldb/trunk/test/lang/cpp/call-function/TestCallCPPFunction.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/lang/cpp/call-function/TestCallCPPFunction.py?rev=245338&r1=245337&r2=245338&view=diff
==============================================================================
--- lldb/trunk/test/lang/cpp/call-function/TestCallCPPFunction.py (original)
+++ lldb/trunk/test/lang/cpp/call-function/TestCallCPPFunction.py Tue Aug 18 15:01:28 2015
@@ -18,6 +18,7 @@ class CallCPPFunctionTestCase(TestBase):
         self.call_cpp_function()
 
     @dwarf_test
+    @expectedFailureWindows("llvm.org/pr24489: Name lookup not working correctly on Windows")
     def test_with_dwarf_and_run_command(self):
         """Test calling a function by basename"""
         self.buildDwarf()

Modified: lldb/trunk/test/lang/cpp/char1632_t/TestChar1632T.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/lang/cpp/char1632_t/TestChar1632T.py?rev=245338&r1=245337&r2=245338&view=diff
==============================================================================
--- lldb/trunk/test/lang/cpp/char1632_t/TestChar1632T.py (original)
+++ lldb/trunk/test/lang/cpp/char1632_t/TestChar1632T.py Tue Aug 18 15:01:28 2015
@@ -21,6 +21,7 @@ class Char1632TestCase(TestBase):
         self.char1632()
 
     @expectedFailureIcc # ICC (13.1) does not emit the DW_TAG_base_type for char16_t and char32_t.
+    @expectedFailureWindows("llvm.org/pr24489: Name lookup not working correctly on Windows")
     @dwarf_test
     def test_with_dwarf(self):
         """Test that the C++11 support for char16_t and char32_t works correctly."""

Modified: lldb/trunk/test/lang/cpp/overloaded-functions/TestOverloadedFunctions.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/lang/cpp/overloaded-functions/TestOverloadedFunctions.py?rev=245338&r1=245337&r2=245338&view=diff
==============================================================================
--- lldb/trunk/test/lang/cpp/overloaded-functions/TestOverloadedFunctions.py (original)
+++ lldb/trunk/test/lang/cpp/overloaded-functions/TestOverloadedFunctions.py Tue Aug 18 15:01:28 2015
@@ -18,6 +18,7 @@ class CPPStaticMethodsTestCase(TestBase)
         self.static_method_commands()
 
     @dwarf_test
+    @expectedFailureWindows("llvm.org/pr24489: Name lookup not working correctly on Windows")
     def test_with_dwarf_and_run_command(self):
         """Test that functions with the same name are resolved correctly"""
         self.buildDwarf()

Modified: lldb/trunk/test/lang/cpp/rdar12991846/TestRdar12991846.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/lang/cpp/rdar12991846/TestRdar12991846.py?rev=245338&r1=245337&r2=245338&view=diff
==============================================================================
--- lldb/trunk/test/lang/cpp/rdar12991846/TestRdar12991846.py (original)
+++ lldb/trunk/test/lang/cpp/rdar12991846/TestRdar12991846.py Tue Aug 18 15:01:28 2015
@@ -35,6 +35,7 @@ class Rdar12991846TestCase(TestBase):
         self.rdar12991846(expr=1)
 
     @unittest2.expectedFailure("rdar://18684408")
+    @expectedFailureWindows("llvm.org/pr24489: Name lookup not working correctly on Windows")
     @dwarf_test
     def test_expr1_with_dwarf(self):
         """Test that the expression parser returns proper Unicode strings."""
@@ -50,6 +51,7 @@ class Rdar12991846TestCase(TestBase):
         self.rdar12991846(expr=2)
 
     @unittest2.expectedFailure("rdar://18684408")
+    @expectedFailureWindows("llvm.org/pr24489: Name lookup not working correctly on Windows")
     @dwarf_test
     def test_expr2_with_dwarf(self):
         """Test that the expression parser returns proper Unicode strings."""
@@ -65,6 +67,7 @@ class Rdar12991846TestCase(TestBase):
         self.rdar12991846(expr=3)
 
     @unittest2.expectedFailure("rdar://18684408")
+    @expectedFailureWindows("llvm.org/pr24489: Name lookup not working correctly on Windows")
     @dwarf_test
     def test_expr3_with_dwarf(self):
         """Test that the expression parser returns proper Unicode strings."""

Modified: lldb/trunk/test/lang/cpp/rvalue-references/TestRvalueReferences.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/lang/cpp/rvalue-references/TestRvalueReferences.py?rev=245338&r1=245337&r2=245338&view=diff
==============================================================================
--- lldb/trunk/test/lang/cpp/rvalue-references/TestRvalueReferences.py (original)
+++ lldb/trunk/test/lang/cpp/rvalue-references/TestRvalueReferences.py Tue Aug 18 15:01:28 2015
@@ -20,6 +20,7 @@ class RvalueReferencesTestCase(TestBase)
 
     #rdar://problem/11479676
     @expectedFailureIcc("ICC (13.1, 14-beta) do not emit DW_TAG_rvalue_reference_type.")
+    @expectedFailureWindows("llvm.org/pr24489: Name lookup not working correctly on Windows")
     @dwarf_test
     def test_with_dwarf_and_run_command(self):
         """Test that rvalues are supported in the C++ expression parser"""

Modified: lldb/trunk/test/lang/cpp/this/TestCPPThis.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/lang/cpp/this/TestCPPThis.py?rev=245338&r1=245337&r2=245338&view=diff
==============================================================================
--- lldb/trunk/test/lang/cpp/this/TestCPPThis.py (original)
+++ lldb/trunk/test/lang/cpp/this/TestCPPThis.py Tue Aug 18 15:01:28 2015
@@ -21,6 +21,8 @@ class CPPThisTestCase(TestBase):
     #rdar://problem/9962849
     @expectedFailureGcc # llvm.org/pr15439 The 'this' pointer isn't available during expression evaluation when stopped in an inlined member function.
     @expectedFailureIcc # ICC doesn't emit correct DWARF inline debug info for inlined member functions
+    @expectedFailureWindows("llvm.org/pr24489: Name lookup not working correctly on Windows")
+    @expectedFailureWindows("llvm.org/pr24490: We shouldn't be using platform-specific names like `getpid` in tests")
     @dwarf_test
     @expectedFlakeyClang(bugnumber='llvm.org/pr23012', compiler_version=['>=','3.6']) # failed with totclang - clang3.7
     def test_with_dwarf_and_run_command(self):




More information about the lldb-commits mailing list