[Lldb-commits] [PATCH] D11094: Refactor Unix signals.

Chaoren Lin chaorenl at google.com
Mon Jul 13 10:28:17 PDT 2015

chaoren added inline comments.

Comment at: source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp:978
@@ +977,3 @@
+    static const auto s_default_unix_signals_sp = std::make_shared<UnixSignals>();
+    return s_default_unix_signals_sp;
ovyalov wrote:
> Should it be Host::GetUnixSignals?
I think it's better to use the default Unix signal set without any assumptions about the remote platform, than to assume that the remote platform would be the same as the host.


More information about the lldb-commits mailing list