[Lldb-commits] [PATCH] D11094: Refactor Unix signals.

Chaoren Lin chaorenl at google.com
Mon Jul 13 10:32:40 PDT 2015


chaoren added inline comments.

================
Comment at: source/API/SBUnixSignals.cpp:111
@@ -98,3 +110,3 @@
 
     if (log)
     {
----------------
ovyalov wrote:
> Please add check for not-null signals_sp
Do we not want to log if it's null?

I think `SBUnixSignals(<null>)::SetShouldSuppress` is still good to see.


http://reviews.llvm.org/D11094







More information about the lldb-commits mailing list