[Lldb-commits] [PATCH] D11094: Refactor Unix signals.

[Oleksiy Vyalov]

ovyalov added inline comments.

================
Comment at: source/API/SBUnixSignals.cpp:111
@@ -98,3 +110,3 @@
 
     if (log)
     {
----------------
Please add check for not-null signals_sp

================
Comment at: source/API/SBUnixSignals.cpp:144
@@ -127,3 +143,3 @@
         log->Printf ("SBUnixSignals(%p)::SetShouldStop (signo=%d, value=%d)",
-                     static_cast<void*>(process_sp.get()),
+                     static_cast<void*>(signals_sp.get()),
                      signo,
----------------
ditto.

================
Comment at: source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp:978
@@ +977,3 @@
+
+    static const auto s_default_unix_signals_sp = std::make_shared<UnixSignals>();
+    return s_default_unix_signals_sp;
----------------
Should it be Host::GetUnixSignals?

================
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp:263
@@ +262,3 @@
+
+    for (auto signo = Host::GetUnixSignals()->GetFirstSignalNumber();
+         signo != LLDB_INVALID_SIGNAL_NUMBER;
----------------
Could you store result of Host::GetUnixSignals() as local variable?

================
Comment at: source/Target/UnixSignals.cpp:343
@@ +342,3 @@
+    auto it = m_signals.begin();
+    std::advance(it, index);
+    return it->first;
----------------
Please add a check that index < m_signals.size()


http://reviews.llvm.org/D11094