[Lldb-commits] [PATCH] Fix argdumper build in cmake (OS X) after r228636

Enrico Granata egranata at apple.com
Tue Feb 10 22:41:37 PST 2015


What about it is Mac-only?

I think it relies on argc/argv, a little JSON producer which is part of LLDB, and printing to stdout.

None of those things seem Mac-only to me.

Sent from my iPhone

> On Feb 10, 2015, at 10:35 PM, Zachary Turner <zturner at google.com> wrote:
> 
> +enrico
> 
> But why is it only for mac? We shouldn't be adding features that are only available on specific platforms without good reason.
>> On Tue, Feb 10, 2015 at 10:31 PM Ilia K <ki.stfu at gmail.com> wrote:
>> As I understood it's for globbing. See here:
>> 
>> - http://llvm.org/viewvc/llvm-project?view=revision&revision=228636
>> - http://llvm.org/viewvc/llvm-project?view=revision&revision=228658
>> - http://llvm.org/viewvc/llvm-project?view=revision&revision=228659
>> 
>> 
>> http://reviews.llvm.org/D7550
>> 
>> EMAIL PREFERENCES
>>   http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150210/7e0285b5/attachment.html>


More information about the lldb-commits mailing list