[Lldb-commits] [lldb] r228584 - Fix MI notification test case on Linux.

Ilia K ki.stfu at gmail.com
Mon Feb 9 10:34:42 PST 2015


Hello Abid,

-        self.expect("\*stopped,reason=\"signal-received\",signal=\"
> 17\",stopped-threads=\"all\"")
> +        self.expect("\*stopped.*")
>
Why did you change *stopped pattern? And why did you do it only in one
place?

Thanks,
Ilia


On Mon, Feb 9, 2015 at 9:14 PM, Hafiz Abid Qadeer <hafiz_abid at mentor.com>
wrote:

> Author: abidh
> Date: Mon Feb  9 12:14:01 2015
> New Revision: 228584
>
> URL: http://llvm.org/viewvc/llvm-project?rev=228584&view=rev
> Log:
> Fix MI notification test case on Linux.
>
> This test case was checking for a specific stop reason which is different
> on
> Linux. This caused the test to fail. It now only checks for stoppped. Also
> added
> some more steps to run to main so that we dont pass when application has
> run to
> completion.
>
>
> Modified:
>     lldb/trunk/test/tools/lldb-mi/TestMiNotification.py
>
> Modified: lldb/trunk/test/tools/lldb-mi/TestMiNotification.py
> URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/test/tools/lldb-mi/TestMiNotification.py?rev=228584&r1=228583&r2=228584&view=diff
>
> ==============================================================================
> --- lldb/trunk/test/tools/lldb-mi/TestMiNotification.py (original)
> +++ lldb/trunk/test/tools/lldb-mi/TestMiNotification.py Mon Feb  9
> 12:14:01 2015
> @@ -63,7 +63,14 @@ class MiNotificationTestCase(lldbmi_test
>          self.expect("\^done")
>
>          # Test that *stopped is printed
> -
> self.expect("\*stopped,reason=\"signal-received\",signal=\"17\",stopped-threads=\"all\"")
> +        self.expect("\*stopped.*")
> +
> +        # Run to main to make sure we have not exited the application
> +        self.runCmd("-break-insert -f main")
> +        self.expect("\^done,bkpt={number=\"1\"")
> +        self.runCmd("-exec-continue")
> +        self.expect("\^running")
> +        self.expect("\*stopped,reason=\"breakpoint-hit\"")
>
>      @lldbmi_test
>      @expectedFailureWindows("llvm.org/pr22274: need a pexpect
> replacement for windows")
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150209/89b3ecc9/attachment.html>


More information about the lldb-commits mailing list