[Lldb-commits] [PATCH] Fix warning about the use of mktemp and make platform agnostic by adding and using PipeBase::CreateWithUniqueName.

Zachary Turner zturner at google.com
Wed Feb 4 10:21:47 PST 2015

Hi Robert, by any chance did you actually try compiling this on Windows?
The reason I ask is that it just occurred to me that this will now require
linking in rpcrt4.lib, which I don't think happens by default.  So this
will cause linker errors.  If you tested it and it compiled, then no
problem.  But if you didn't test it, then I think it's better to just go
back to the way it was before, and I will do the UuidToString stuff later.

On Wed Feb 04 2015 at 10:08:19 AM Robert Flack <flackr at gmail.com> wrote:

> Addressed review comments, namely storing a std::string for the m_name
> member of Pipe(Posix|Windows), using UuidCreate to generate the random pipe
> name in PipeWindows::CreateWithUniqueName, and referencing the name
> directly in GDBRemoteCommunication.cpp.
>   rL LLVM
> http://reviews.llvm.org/D7348
> Files:
>   include/lldb/Host/PipeBase.h
>   include/lldb/Host/posix/PipePosix.h
>   include/lldb/Host/windows/PipeWindows.h
>   source/Host/posix/PipePosix.cpp
>   source/Host/windows/PipeWindows.cpp
>   source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
>   http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150204/445e603c/attachment.html>

More information about the lldb-commits mailing list