<div dir="ltr">Hi Robert, by any chance did you actually try compiling this on Windows?  The reason I ask is that it just occurred to me that this will now require linking in rpcrt4.lib, which I don't think happens by default.  So this will cause linker errors.  If you tested it and it compiled, then no problem.  But if you didn't test it, then I think it's better to just go back to the way it was before, and I will do the UuidToString stuff later.<br></div><br><div class="gmail_quote">On Wed Feb 04 2015 at 10:08:19 AM Robert Flack <<a href="mailto:flackr@gmail.com">flackr@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Addressed review comments, namely storing a std::string for the m_name member of Pipe(Posix|Windows), using UuidCreate to generate the random pipe name in PipeWindows::<u></u>CreateWithUniqueName, and referencing the name directly in GDBRemoteCommunication.cpp.<br>
<br>
<br>
REPOSITORY<br>
  rL LLVM<br>
<br>
<a href="http://reviews.llvm.org/D7348" target="_blank">http://reviews.llvm.org/D7348</a><br>
<br>
Files:<br>
  include/lldb/Host/PipeBase.h<br>
  include/lldb/Host/posix/<u></u>PipePosix.h<br>
  include/lldb/Host/windows/<u></u>PipeWindows.h<br>
  source/Host/posix/PipePosix.<u></u>cpp<br>
  source/Host/windows/<u></u>PipeWindows.cpp<br>
  source/Plugins/Process/gdb-<u></u>remote/GDBRemoteCommunication.<u></u>cpp<br>
<br>
EMAIL PREFERENCES<br>
  <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/<u></u>settings/panel/<u></u>emailpreferences/</a><br>
</blockquote></div>