[Lldb-commits] [PATCH] Fix warning about the use of mktemp and make platform agnostic by adding and using PipeBase::CreateWithUniqueName.
Robert Flack
flackr at gmail.com
Wed Feb 4 10:08:12 PST 2015
Addressed review comments, namely storing a std::string for the m_name member of Pipe(Posix|Windows), using UuidCreate to generate the random pipe name in PipeWindows::CreateWithUniqueName, and referencing the name directly in GDBRemoteCommunication.cpp.
REPOSITORY
rL LLVM
http://reviews.llvm.org/D7348
Files:
include/lldb/Host/PipeBase.h
include/lldb/Host/posix/PipePosix.h
include/lldb/Host/windows/PipeWindows.h
source/Host/posix/PipePosix.cpp
source/Host/windows/PipeWindows.cpp
source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7348.19332.patch
Type: text/x-patch
Size: 11043 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150204/26ed2bce/attachment.bin>
More information about the lldb-commits
mailing list