[Lldb-commits] [PATCH] [2/2] Fix Path support on Windows
zturner at google.com
Wed Jul 30 14:35:52 PDT 2014
Ping. This patch doesn't seem too risky to me, but just in case anyone has
concerns, I'll leave it up for another day or two to give others a chance
to look at it. Please speak up if you want me to hold off on comitting
On Tue, Jul 29, 2014 at 10:36 AM, Zachary Turner <zturner at google.com> wrote:
> Sorry, responding to the original message in the thread means that an old
> version of the patch was attached. The newest version of the patch is
> attached to this email.
> On Tue, Jul 29, 2014 at 10:34 AM, Zachary Turner <zturner at google.com>
>> Greg, any objections to / comments on this patch before I submit it?
>> On Fri, Jul 25, 2014 at 11:52 AM, Zachary Turner <zturner at google.com>
>>> Hi deepak2427,
>>> This gives FileSpec the notion of a path syntax, of which there are 3.
>>> Unix Native, Windows Native, and Host Native, which chooses between Unix
>>> and Linux automatically. This allows cross-platform support (e.g. storing
>>> a Unix Path on a Windows Host).
>>> There are remaining Path issues in PathMappingList. These should be
>>> fixed independently by storing FileSpecs instead of ConstStrings, and using
>>> the fixes in this patch. Alternatively, llvm::sys::path contains path
>>> methods that might help here.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-commits