[Lldb-commits] [PATCH] [2/2] Fix Path support on Windows

Deepak Panickal deepak2427 at gmail.com
Wed Jul 30 16:26:27 PDT 2014


Thanks for fixing this. I haven't had a chance to test this patch with our cross-platform issues yet, have to look at some other issues first. 
Just a couple of doubts I had.

- Are the paths always going to default as ePathSyntaxHostNative and then converted based on the Host?
- In 733       llvm::SmallString<64> denormalized; , is the length of 64 enough?
- I'm not that familiar with LLVM data structures, however would it be better to keep llvm::SmallString itself for the Normalize/Denormalize functions to keep it consistent?

http://reviews.llvm.org/D4675






More information about the lldb-commits mailing list