[Lldb-commits] [PATCH] [2/2] Fix Path support on Windows

[Zachary Turner]

Sorry, responding to the original message in the thread means that an old
version of the patch was attached.  The newest version of the patch is
attached to this email.


On Tue, Jul 29, 2014 at 10:34 AM, Zachary Turner <zturner at google.com> wrote:

> +greg.
>
> Greg, any objections to / comments on this patch before I submit it?
>
>
> On Fri, Jul 25, 2014 at 11:52 AM, Zachary Turner <zturner at google.com>
> wrote:
>
>> Hi deepak2427,
>>
>> This gives FileSpec the notion of a path syntax, of which there are 3.
>>  Unix Native, Windows Native, and Host Native, which chooses between Unix
>> and Linux automatically.  This allows cross-platform support (e.g. storing
>> a Unix Path on a Windows Host).
>>
>> There are remaining Path issues in PathMappingList.  These should be
>> fixed independently by storing FileSpecs instead of ConstStrings, and using
>> the fixes in this patch.  Alternatively, llvm::sys::path contains path
>> methods that might help here.
>>
>> http://reviews.llvm.org/D4675
>>
>> Files:
>>   include/lldb/Host/FileSpec.h
>>   include/lldb/Host/Host.h
>>   source/Host/common/FileSpec.cpp
>>   source/Host/common/Host.cpp
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140729/96fbe73e/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D4675.11898.patch
Type: application/octet-stream
Size: 10989 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140729/96fbe73e/attachment.obj>