[Lldb-commits] MSVC12 support

[Virgile Bello]

Here is an updated MSVC2013 patch with what's not merged yet. Much smaller
than before!


On Thu, Sep 5, 2013 at 2:07 AM, Greg Clayton <gclayton at apple.com> wrote:

> Looks fine to me.
>
> On Sep 4, 2013, at 9:19 AM, Virgile Bello <virgile.bello at gmail.com> wrote:
>
> > Would such a patch be OK for getopt? (with OptionParser.h)
> > Didn't try to hide actual getopt architecture, but at least it prevents
> <getopt.h> from being included directly.
> >
> > If this gets accepted, the remaining part of MSVC patch should be quite
> small.
> >
> >
> > On Thu, Aug 29, 2013 at 5:02 AM, Greg Clayton <gclayton at apple.com>
> wrote:
> > Yes in general to abstract ourselves from the system on which we are
> compiling:
> >
> > 1 - First try and use LLVM functionality where it makes sense
> > 2 - Use LLDB Host layer
> > 3 - Use #ifdef in .cpp files only if possible
> > 4 - Use $ifdef in .h files as a last resort.
> >
> > To get back to the "getopt.h" stuff, it would be great to make a Host
> class that abstracts us from the "getopt.h" functionality.
> >
> > Something like "include/lldb/Host/OptionParser.h" and then a .cpp file
> in common that hides the abstraction for the actual unix version that is
> used for everything but windows, and a windows specific one that could use
> a compatibility layer...
> >
> > Greg
> >
> > On Aug 28, 2013, at 9:35 AM, Virgile Bello <virgile.bello at gmail.com>
> wrote:
> >
> > > Ha yes sure, I thought that was not recommended since LLVM was not
> used for many other similar situations (i.e. Mutex, Regex, Argument parsing
> vs getopt, some path functions, etc...).
> > > But I suppose it is maybe due more to the fact it wasn't good/stable
> enough at the time you needed it, and switch would be OK now?
> > >
> > >
> > > On Thu, Aug 29, 2013 at 1:07 AM, João Matos <ripzonetriton at gmail.com>
> wrote:
> > > +#ifdef _MSC_VER
> > > +        InterlockedIncrement(&m_last_revision);
> > > +#else
> > >          __sync_add_and_fetch(&m_last_revision, +1);
> > > +#endif
> > >
> > > I see this pattern ifdef'd in a lot of places, I think we should
> abstract it in an helper "atomics" function, or even better, just re-use
> LLVM support libraries (llvm::sys::AtomicIncrement).
> > >
> > >
> > > --
> > > João Matos
> > >
> > > _______________________________________________
> > > lldb-commits mailing list
> > > lldb-commits at cs.uiuc.edu
> > > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
> >
> >
> > <lldb-getopt.diff>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20130907/dfdd4c6c/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lldb-msvc12-v3.diff
Type: application/octet-stream
Size: 11298 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20130907/dfdd4c6c/attachment.obj>