[Lldb-commits] [lldb] r169633 - in /lldb/trunk: source/ source/API/ source/Core/ source/Host/common/ source/Interpreter/ source/Plugins/ABI/MacOSX-i386/ source/Plugins/DynamicLoader/Darwin-Kernel/ source/Plugins/DynamicLoader/MacOSX-DYLD/ source/Plugi
Kaylor, Andrew
andrew.kaylor at intel.com
Fri Dec 7 17:09:49 PST 2012
Will the current build settings produce an error for an uncovered switch case with no default?
If not, this patch makes it pretty important for us to keep the build free of warnings so we don't miss new uncovered cases appearing.
-Andy
-----Original Message-----
From: lldb-commits-bounces at cs.uiuc.edu [mailto:lldb-commits-bounces at cs.uiuc.edu] On Behalf Of Daniel Malea
Sent: Friday, December 07, 2012 12:51 PM
To: lldb-commits at cs.uiuc.edu
Subject: [Lldb-commits] [lldb] r169633 - in /lldb/trunk: source/ source/API/ source/Core/ source/Host/common/ source/Interpreter/ source/Plugins/ABI/MacOSX-i386/ source/Plugins/DynamicLoader/Darwin-Kernel/ source/Plugins/DynamicLoader/MacOSX-DYLD/ source/Plugin...
Author: dmalea
Date: Fri Dec 7 14:51:09 2012
New Revision: 169633
URL: http://llvm.org/viewvc/llvm-project?rev=169633&view=rev
Log:
More Linux warnings fixes (remove default labels as needed):
- as per http://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumerations
Patch by Matt Kopec!
Modified:
lldb/trunk/source/API/SBValue.cpp
lldb/trunk/source/Core/Communication.cpp
lldb/trunk/source/Core/DataExtractor.cpp
lldb/trunk/source/Core/EmulateInstruction.cpp
lldb/trunk/source/Core/RegisterValue.cpp
lldb/trunk/source/Core/Scalar.cpp
lldb/trunk/source/Core/State.cpp
lldb/trunk/source/Core/Value.cpp
lldb/trunk/source/Core/ValueObject.cpp
lldb/trunk/source/Core/ValueObjectChild.cpp
lldb/trunk/source/Core/ValueObjectConstResult.cpp
lldb/trunk/source/Host/common/FileSpec.cpp
lldb/trunk/source/Host/common/Host.cpp
lldb/trunk/source/Host/common/Mutex.cpp
lldb/trunk/source/Interpreter/CommandInterpreter.cpp
lldb/trunk/source/Interpreter/ScriptInterpreterPython.cpp
lldb/trunk/source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.cpp
lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp
lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp
lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp
lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp
lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.h
lldb/trunk/source/Plugins/Process/POSIX/ProcessMessage.cpp
lldb/trunk/source/Plugins/Process/POSIX/ProcessPOSIX.cpp
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp
lldb/trunk/source/Symbol/ClangASTContext.cpp
lldb/trunk/source/Target/Process.cpp
lldb/trunk/source/lldb.cpp
lldb/trunk/tools/driver/Driver.cpp
Modified: lldb/trunk/source/API/SBValue.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/API/SBValue.cpp?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/source/API/SBValue.cpp (original)
+++ lldb/trunk/source/API/SBValue.cpp Fri Dec 7 14:51:09 2012
@@ -388,7 +388,6 @@
case eValueTypeRegister: log->Printf ("SBValue(%p)::GetValueType () => eValueTypeRegister", value_sp.get()); break;
case eValueTypeRegisterSet: log->Printf ("SBValue(%p)::GetValueType () => eValueTypeRegisterSet", value_sp.get()); break;
case eValueTypeConstResult: log->Printf ("SBValue(%p)::GetValueType () => eValueTypeConstResult", value_sp.get()); break;
- default: log->Printf ("SBValue(%p)::GetValueType () => %i ???", value_sp.get(), result); break;
}
}
return result;
Modified: lldb/trunk/source/Core/Communication.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/Communication.cpp?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/source/Core/Communication.cpp (original)
+++ lldb/trunk/source/Core/Communication.cpp Fri Dec 7 14:51:09 2012
@@ -374,7 +374,6 @@
case eConnectionStatusLostConnection: // Lost connection while connected to a valid connection
done = true;
// Fall through...
- default:
case eConnectionStatusError: // Check GetError() for details
case eConnectionStatusTimedOut: // Request timed out
if (log)
Modified: lldb/trunk/source/Core/DataExtractor.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/DataExtractor.cpp?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/source/Core/DataExtractor.cpp (original)
+++ lldb/trunk/source/Core/DataExtractor.cpp Fri Dec 7 14:51:09 2012
@@ -1928,7 +1928,6 @@
switch (type)
{
- default:
case TypeUInt8: sstr.Printf (format ? format : " %2.2x", GetU8(&offset)); break;
case TypeChar:
{
Modified: lldb/trunk/source/Core/EmulateInstruction.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/EmulateInstruction.cpp?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/source/Core/EmulateInstruction.cpp (original)
+++ lldb/trunk/source/Core/EmulateInstruction.cpp Fri Dec 7 14:51:09
+++ 2012
@@ -587,10 +587,6 @@
case eInfoTypeNoArgs:
break;
-
- default:
- strm.Printf (" (unknown <info_type>)");
- break;
}
}
Modified: lldb/trunk/source/Core/RegisterValue.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/RegisterValue.cpp?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/source/Core/RegisterValue.cpp (original)
+++ lldb/trunk/source/Core/RegisterValue.cpp Fri Dec 7 14:51:09 2012
@@ -450,7 +450,6 @@
const uint32_t byte_size = reg_info->byte_size;
switch (reg_info->encoding)
{
- default:
case eEncodingInvalid:
error.SetErrorString ("Invalid encoding.");
break;
@@ -637,7 +636,6 @@
m_type = rhs.m_type;
switch (m_type)
{
- default:
case eTypeInvalid:
return false;
case eTypeUInt8: m_data.uint8 = rhs.m_data.uint8; break;
Modified: lldb/trunk/source/Core/Scalar.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/Scalar.cpp?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/source/Core/Scalar.cpp (original)
+++ lldb/trunk/source/Core/Scalar.cpp Fri Dec 7 14:51:09 2012
@@ -169,7 +169,6 @@
{
switch (m_type)
{
- default:
case e_void:
break;
case e_sint: return sizeof(m_data.sint);
@@ -190,7 +189,6 @@
{
switch (m_type)
{
- default:
case e_void:
break;
case e_sint: return m_data.sint == 0;
@@ -215,7 +213,6 @@
switch (m_type)
{
case e_void:
- default:
break;
case e_sint: s->Printf("%i", m_data.sint); break;
case e_uint: s->Printf("0x%8.8x", m_data.uint); break;
@@ -234,8 +231,6 @@
{
switch (m_type)
{
- default:
- break;
case e_void: return "void";
case e_sint: return "int";
case e_uint: return "unsigned int";
@@ -358,7 +353,6 @@
case e_sint:
switch (type)
{
- default:
case e_void: break;
case e_sint: success = true; break;
case e_uint: m_data.uint = m_data.sint; success = true; break;
@@ -375,7 +369,6 @@
case e_uint:
switch (type)
{
- default:
case e_void:
case e_sint: break;
case e_uint: success = true; break;
@@ -392,7 +385,6 @@
case e_slong:
switch (type)
{
- default:
case e_void:
case e_sint:
case e_uint: break;
@@ -409,7 +401,6 @@
case e_ulong:
switch (type)
{
- default:
case e_void:
case e_sint:
case e_uint:
@@ -426,7 +417,6 @@
case e_slonglong:
switch (type)
{
- default:
case e_void:
case e_sint:
case e_uint:
@@ -443,7 +433,6 @@
case e_ulonglong:
switch (type)
{
- default:
case e_void:
case e_sint:
case e_uint:
@@ -460,7 +449,6 @@
case e_float:
switch (type)
{
- default:
case e_void:
case e_sint:
case e_uint:
@@ -477,7 +465,6 @@
case e_double:
switch (type)
{
- default:
case e_void:
case e_sint:
case e_uint:
@@ -494,7 +481,6 @@
case e_long_double:
switch (type)
{
- default:
case e_void:
case e_sint:
case e_uint:
@@ -519,7 +505,6 @@
{
switch (type)
{
- default: break;
case e_void: return "void";
case e_sint: return "int";
case e_uint: return "unsigned int";
@@ -583,7 +568,6 @@
case e_sint:
switch (type)
{
- default:
case e_void: break;
case e_sint: success = true; break;
case e_uint: m_data.uint = m_data.sint; success = true; break;
@@ -600,7 +584,6 @@
case e_uint:
switch (type)
{
- default:
case e_void:
case e_sint: m_data.sint = m_data.uint; success = true; break;
case e_uint: success = true; break;
@@ -617,7 +600,6 @@
case e_slong:
switch (type)
{
- default:
case e_void:
case e_sint: m_data.sint = m_data.slong; success = true; break;
case e_uint: m_data.uint = m_data.slong; success = true; break;
@@ -634,7 +616,6 @@
case e_ulong:
switch (type)
{
- default:
case e_void:
case e_sint: m_data.sint = m_data.ulong; success = true; break;
case e_uint: m_data.uint = m_data.ulong; success = true; break;
@@ -651,7 +632,6 @@
case e_slonglong:
switch (type)
{
- default:
case e_void:
case e_sint: m_data.sint = m_data.slonglong; success = true; break;
case e_uint: m_data.uint = m_data.slonglong; success = true; break;
@@ -668,7 +648,6 @@
case e_ulonglong:
switch (type)
{
- default:
case e_void:
case e_sint: m_data.sint = m_data.ulonglong; success = true; break;
case e_uint: m_data.uint = m_data.ulonglong; success = true; break;
@@ -685,7 +664,6 @@
case e_float:
switch (type)
{
- default:
case e_void:
case e_sint: m_data.sint = m_data.flt; success = true; break;
case e_uint: m_data.uint = m_data.flt; success = true; break;
@@ -702,7 +680,6 @@
case e_double:
switch (type)
{
- default:
case e_void:
case e_sint: m_data.sint = m_data.dbl; success = true; break;
case e_uint: m_data.uint = m_data.dbl; success = true; break;
@@ -719,7 +696,6 @@
case e_long_double:
switch (type)
{
- default:
case e_void:
case e_sint: m_data.sint = m_data.ldbl; success = true; break;
case e_uint: m_data.uint = m_data.ldbl; success = true; break;
@@ -744,7 +720,6 @@
{
switch (m_type)
{
- default:
case e_void: break;
case e_sint: return m_data.sint;
case e_uint: return (int)m_data.uint;
@@ -764,7 +739,6 @@
{
switch (m_type)
{
- default:
case e_void: break;
case e_sint: return (unsigned int)m_data.sint;
case e_uint: return (unsigned int)m_data.uint;
@@ -785,7 +759,6 @@
{
switch (m_type)
{
- default:
case e_void: break;
case e_sint: return (long)m_data.sint;
case e_uint: return (long)m_data.uint;
@@ -807,7 +780,6 @@
{
switch (m_type)
{
- default:
case e_void: break;
case e_sint: return (unsigned long)m_data.sint;
case e_uint: return (unsigned long)m_data.uint;
@@ -827,7 +799,6 @@
{
switch (m_type)
{
- default:
case e_void:
break;
@@ -880,7 +851,6 @@
{
switch (m_type)
{
- default:
case e_void: break;
case e_sint: return (long long)m_data.sint;
case e_uint: return (long long)m_data.uint;
@@ -901,7 +871,6 @@
{
switch (m_type)
{
- default:
case e_void: break;
case e_sint: return (unsigned long long)m_data.sint;
case e_uint: return (unsigned long long)m_data.uint;
@@ -922,7 +891,6 @@
{
switch (m_type)
{
- default:
case e_void: break;
case e_sint: return (float)m_data.sint;
case e_uint: return (float)m_data.uint;
@@ -943,7 +911,6 @@
{
switch (m_type)
{
- default:
case e_void: break;
case e_sint: return (double)m_data.sint;
case e_uint: return (double)m_data.uint;
@@ -964,7 +931,6 @@
{
switch (m_type)
{
- default:
case e_void: break;
case e_sint: return (long double)m_data.sint;
case e_uint: return (long double)m_data.uint;
@@ -990,7 +956,6 @@
{
switch (m_type)
{
- default:
case e_void: break;
case e_sint: m_data.sint = a->m_data.sint + b->m_data.sint; break;
case e_uint: m_data.uint = a->m_data.uint + b->m_data.uint; break;
@@ -1011,7 +976,6 @@
{
switch (m_type)
{
- default:
case e_void:
case e_float:
case e_double:
@@ -1022,7 +986,6 @@
case e_sint:
switch (rhs.m_type)
{
- default:
case e_void:
case e_float:
case e_double:
@@ -1041,7 +1004,6 @@
case e_uint:
switch (rhs.m_type)
{
- default:
case e_void:
case e_float:
case e_double:
@@ -1060,7 +1022,6 @@
case e_slong:
switch (rhs.m_type)
{
- default:
case e_void:
case e_float:
case e_double:
@@ -1079,7 +1040,6 @@
case e_ulong:
switch (rhs.m_type)
{
- default:
case e_void:
case e_float:
case e_double:
@@ -1097,7 +1057,6 @@
case e_slonglong:
switch (rhs.m_type)
{
- default:
case e_void:
case e_float:
case e_double:
@@ -1116,7 +1075,6 @@
case e_ulonglong:
switch (rhs.m_type)
{
- default:
case e_void:
case e_float:
case e_double:
@@ -1140,7 +1098,6 @@
{
switch (m_type)
{
- default:
case e_void:
case e_float:
case e_double:
@@ -1152,7 +1109,6 @@
case e_uint:
switch (rhs.m_type)
{
- default:
case e_void:
case e_float:
case e_double:
@@ -1172,7 +1128,6 @@
case e_ulong:
switch (rhs.m_type)
{
- default:
case e_void:
case e_float:
case e_double:
@@ -1192,7 +1147,6 @@
case e_ulonglong:
switch (rhs.m_type)
{
- default:
case e_void:
case e_float:
case e_double:
@@ -1217,7 +1171,6 @@
{
switch (m_type)
{
- default:
case e_void:
case e_float:
case e_double:
@@ -1228,7 +1181,6 @@
case e_sint:
switch (rhs.m_type)
{
- default:
case e_void:
case e_float:
case e_double:
@@ -1247,7 +1199,6 @@
case e_uint:
switch (rhs.m_type)
{
- default:
case e_void:
case e_float:
case e_double:
@@ -1266,7 +1217,6 @@
case e_slong:
switch (rhs.m_type)
{
- default:
case e_void:
case e_float:
case e_double:
@@ -1285,7 +1235,6 @@
case e_ulong:
switch (rhs.m_type)
{
- default:
case e_void:
case e_float:
case e_double:
@@ -1303,7 +1252,6 @@
case e_slonglong:
switch (rhs.m_type)
{
- default:
case e_void:
case e_float:
case e_double:
@@ -1322,7 +1270,6 @@
case e_ulonglong:
switch (rhs.m_type)
{
- default:
case e_void:
case e_float:
case e_double:
@@ -1347,7 +1294,6 @@
{
switch (m_type)
{
- default:
case e_void:
case e_float:
case e_double:
@@ -1358,7 +1304,6 @@
case e_sint:
switch (rhs.m_type)
{
- default:
case e_void:
case e_float:
case e_double:
@@ -1377,7 +1322,6 @@
case e_uint:
switch (rhs.m_type)
{
- default:
case e_void:
case e_float:
case e_double:
@@ -1396,7 +1340,6 @@
case e_slong:
switch (rhs.m_type)
{
- default:
case e_void:
case e_float:
case e_double:
@@ -1415,7 +1358,6 @@
case e_ulong:
switch (rhs.m_type)
{
- default:
case e_void:
case e_float:
case e_double:
@@ -1433,7 +1375,6 @@
case e_slonglong:
switch (rhs.m_type)
{
- default:
case e_void:
case e_float:
case e_double:
@@ -1452,7 +1393,6 @@
case e_ulonglong:
switch (rhs.m_type)
{
- default:
case e_void:
case e_float:
case e_double:
@@ -1478,7 +1418,6 @@
{
switch (m_type)
{
- default:
case e_void:
break;
@@ -1513,7 +1452,6 @@
{
switch (m_type)
{
- default:
case e_void: break;
case e_sint: m_data.sint = -m_data.sint; return true;
case e_uint: m_data.uint = -m_data.uint; return true;
@@ -1540,7 +1478,6 @@
case e_slonglong: m_data.slonglong = ~m_data.slonglong; return true;
case e_ulonglong: m_data.ulonglong = ~m_data.ulonglong; return true;
- default:
case e_void:
case e_float:
case e_double:
@@ -1562,7 +1499,6 @@
{
switch (result.m_type)
{
- default:
case Scalar::e_void: break;
case Scalar::e_sint: result.m_data.sint = a->m_data.sint + b->m_data.sint; break;
case Scalar::e_uint: result.m_data.uint = a->m_data.uint + b->m_data.uint; break;
@@ -1590,7 +1526,6 @@
{
switch (result.m_type)
{
- default:
case Scalar::e_void: break;
case Scalar::e_sint: result.m_data.sint = a->m_data.sint - b->m_data.sint; break;
case Scalar::e_uint: result.m_data.uint = a->m_data.uint - b->m_data.uint; break;
@@ -1617,7 +1552,6 @@
{
switch (result.m_type)
{
- default:
case Scalar::e_void: break;
case Scalar::e_sint: if (b->m_data.sint != 0) { result.m_data.sint = a->m_data.sint/ b->m_data.sint; return result; } break;
@@ -1648,7 +1582,6 @@
{
switch (result.m_type)
{
- default:
case Scalar::e_void: break;
case Scalar::e_sint: result.m_data.sint = a->m_data.sint * b->m_data.sint; break;
case Scalar::e_uint: result.m_data.uint = a->m_data.uint * b->m_data.uint; break;
@@ -1682,7 +1615,6 @@
case Scalar::e_slonglong: result.m_data.slonglong = a->m_data.slonglong & b->m_data.slonglong; break;
case Scalar::e_ulonglong: result.m_data.ulonglong = a->m_data.ulonglong & b->m_data.ulonglong; break;
- default:
case Scalar::e_void:
case Scalar::e_float:
case Scalar::e_double:
@@ -1713,7 +1645,6 @@
case Scalar::e_slonglong: result.m_data.slonglong = a->m_data.slonglong | b->m_data.slonglong; break;
case Scalar::e_ulonglong: result.m_data.ulonglong = a->m_data.ulonglong | b->m_data.ulonglong; break;
- default:
case Scalar::e_void:
case Scalar::e_float:
case Scalar::e_double:
@@ -1744,7 +1675,6 @@
case Scalar::e_slonglong: result.m_data.slonglong = a->m_data.slonglong % b->m_data.slonglong; break;
case Scalar::e_ulonglong: result.m_data.ulonglong = a->m_data.ulonglong % b->m_data.ulonglong; break;
- default:
case Scalar::e_void:
case Scalar::e_float:
case Scalar::e_double:
@@ -1775,7 +1705,6 @@
case Scalar::e_slonglong: result.m_data.slonglong = a->m_data.slonglong ^ b->m_data.slonglong; break;
case Scalar::e_ulonglong: result.m_data.ulonglong = a->m_data.ulonglong ^ b->m_data.ulonglong; break;
- default:
case Scalar::e_void:
case Scalar::e_float:
case Scalar::e_double:
@@ -1822,7 +1751,6 @@
bool success = false;
switch (encoding)
{
- default:
case eEncodingInvalid:
error.SetErrorString ("Invalid encoding.");
break;
@@ -1933,7 +1861,6 @@
{
switch (m_type)
{
- default:
case Scalar::e_void:
case Scalar::e_float:
case Scalar::e_double:
@@ -2031,7 +1958,6 @@
uint32_t lsbit = bit_offset;
switch (m_type)
{
- default:
case Scalar::e_void:
break;
@@ -2111,7 +2037,6 @@
const Scalar* b;
switch (PromoteToMaxType(lhs, rhs, temp_value, a, b))
{
- default:
case Scalar::e_void: break;
case Scalar::e_sint: return a->m_data.sint == b->m_data.sint;
case Scalar::e_uint: return a->m_data.uint == b->m_data.uint;
@@ -2138,7 +2063,6 @@
const Scalar* b;
switch (PromoteToMaxType(lhs, rhs, temp_value, a, b))
{
- default:
case Scalar::e_void: break;
case Scalar::e_sint: return a->m_data.sint != b->m_data.sint;
case Scalar::e_uint: return a->m_data.uint != b->m_data.uint;
@@ -2164,7 +2088,6 @@
const Scalar* b;
switch (PromoteToMaxType(lhs, rhs, temp_value, a, b))
{
- default:
case Scalar::e_void: break;
case Scalar::e_sint: return a->m_data.sint < b->m_data.sint;
case Scalar::e_uint: return a->m_data.uint < b->m_data.uint;
@@ -2190,7 +2113,6 @@
const Scalar* b;
switch (PromoteToMaxType(lhs, rhs, temp_value, a, b))
{
- default:
case Scalar::e_void: break;
case Scalar::e_sint: return a->m_data.sint <= b->m_data.sint;
case Scalar::e_uint: return a->m_data.uint <= b->m_data.uint;
@@ -2217,7 +2139,6 @@
const Scalar* b;
switch (PromoteToMaxType(lhs, rhs, temp_value, a, b))
{
- default:
case Scalar::e_void: break;
case Scalar::e_sint: return a->m_data.sint > b->m_data.sint;
case Scalar::e_uint: return a->m_data.uint > b->m_data.uint;
@@ -2243,7 +2164,6 @@
const Scalar* b;
switch (PromoteToMaxType(lhs, rhs, temp_value, a, b))
{
- default:
case Scalar::e_void: break;
case Scalar::e_sint: return a->m_data.sint >= b->m_data.sint;
case Scalar::e_uint: return a->m_data.uint >= b->m_data.uint;
Modified: lldb/trunk/source/Core/State.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/State.cpp?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/source/Core/State.cpp (original)
+++ lldb/trunk/source/Core/State.cpp Fri Dec 7 14:51:09 2012
@@ -83,7 +83,6 @@
case eStateCrashed:
case eStateExited:
case eStateSuspended:
- default:
break;
}
return false;
@@ -101,7 +100,6 @@
case eStateRunning:
case eStateStepping:
case eStateDetached:
- default:
break;
case eStateUnloaded:
Modified: lldb/trunk/source/Core/Value.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/Value.cpp?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/source/Core/Value.cpp (original)
+++ lldb/trunk/source/Core/Value.cpp Fri Dec 7 14:51:09 2012
@@ -156,7 +156,6 @@
{
switch (m_context_type)
{
- default:
case eContextTypeInvalid:
case eContextTypeClangType: // clang::Type *
case eContextTypeRegisterInfo: // RegisterInfo *
@@ -177,7 +176,6 @@
switch (m_context_type)
{
- default:
case eContextTypeInvalid:
// If we have no context, there is no way to know how much memory to read
if (error_ptr)
@@ -244,7 +242,6 @@
{
switch (m_context_type)
{
- default:
case eContextTypeInvalid:
break;
@@ -273,7 +270,6 @@
{
switch (m_context_type)
{
- default:
case eContextTypeInvalid:
break;
Modified: lldb/trunk/source/Core/ValueObject.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/ValueObject.cpp?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/source/Core/ValueObject.cpp (original)
+++ lldb/trunk/source/Core/ValueObject.cpp Fri Dec 7 14:51:09 2012
@@ -420,9 +420,6 @@
switch (m_value.GetValueType())
{
- default:
- break;
-
case Value::eValueTypeScalar:
case Value::eValueTypeVector:
if (m_value.GetContextType() == Value::eContextTypeRegisterInfo) @@ -926,7 +923,6 @@
}
break;
case eAddressTypeInvalid:
- default:
break;
}
}
@@ -1524,9 +1520,6 @@
case eValueObjectRepresentationStyleType:
return_value = GetTypeName().AsCString();
break;
-
- default:
- break;
}
if (!return_value)
@@ -3674,7 +3667,6 @@
{
switch (address_type)
{
- default:
case eAddressTypeInvalid:
{
StreamString expr_path_strm;
Modified: lldb/trunk/source/Core/ValueObjectChild.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/ValueObjectChild.cpp?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/source/Core/ValueObjectChild.cpp (original)
+++ lldb/trunk/source/Core/ValueObjectChild.cpp Fri Dec 7 14:51:09 2012
@@ -164,7 +164,6 @@
m_value.SetValueType(Value::eValueTypeHostAddress);
break;
case eAddressTypeInvalid:
- default:
// TODO: does this make sense?
m_value.SetValueType(Value::eValueTypeScalar);
break;
Modified: lldb/trunk/source/Core/ValueObjectConstResult.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/ValueObjectConstResult.cpp?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/source/Core/ValueObjectConstResult.cpp (original)
+++ lldb/trunk/source/Core/ValueObjectConstResult.cpp Fri Dec 7
+++ 14:51:09 2012
@@ -219,7 +219,6 @@
//m_value.SetValueType(Value::eValueTypeHostAddress);
switch (address_type)
{
- default:
case eAddressTypeInvalid: m_value.SetValueType(Value::eValueTypeScalar); break;
case eAddressTypeFile: m_value.SetValueType(Value::eValueTypeFileAddress); break;
case eAddressTypeLoad: m_value.SetValueType(Value::eValueTypeLoadAddress); break;
Modified: lldb/trunk/source/Host/common/FileSpec.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/FileSpec.cpp?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/source/Host/common/FileSpec.cpp (original)
+++ lldb/trunk/source/Host/common/FileSpec.cpp Fri Dec 7 14:51:09 2012
@@ -938,7 +938,6 @@
switch (result)
{
- default:
case eEnumerateDirectoryResultNext:
// Enumerate next entry in the current directory. We just
// exit this switch and will continue enumerating the
Modified: lldb/trunk/source/Host/common/Host.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/Host.cpp?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/source/Host/common/Host.cpp (original)
+++ lldb/trunk/source/Host/common/Host.cpp Fri Dec 7 14:51:09 2012
@@ -1093,9 +1093,6 @@
// TODO: where would user LLDB plug-ins be located on linux? Other systems?
return false;
}
- default:
- assert (!"Unhandled PathType");
- break;
}
return false;
Modified: lldb/trunk/source/Host/common/Mutex.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/Mutex.cpp?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/source/Host/common/Mutex.cpp (original)
+++ lldb/trunk/source/Host/common/Mutex.cpp Fri Dec 7 14:51:09 2012
@@ -218,10 +218,6 @@
case eMutexTypeRecursive:
err = ::pthread_mutexattr_settype (&attr, PTHREAD_MUTEX_RECURSIVE);
break;
-
- default:
- err = -1;
- break;
}
assert(err == 0);
err = ::pthread_mutex_init (&m_mutex, &attr);
Modified: lldb/trunk/source/Interpreter/CommandInterpreter.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Interpreter/CommandInterpreter.cpp?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/source/Interpreter/CommandInterpreter.cpp (original)
+++ lldb/trunk/source/Interpreter/CommandInterpreter.cpp Fri Dec 7
+++ 14:51:09 2012
@@ -2589,8 +2589,6 @@
case eScriptLanguageNone:
m_script_interpreter_ap.reset (new ScriptInterpreterNone (*this));
break;
- default:
- break;
};
return m_script_interpreter_ap.get();
Modified: lldb/trunk/source/Interpreter/ScriptInterpreterPython.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Interpreter/ScriptInterpreterPython.cpp?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/source/Interpreter/ScriptInterpreterPython.cpp (original)
+++ lldb/trunk/source/Interpreter/ScriptInterpreterPython.cpp Fri Dec 7
+++ 14:51:09 2012
@@ -1131,8 +1131,6 @@
success = PyArg_Parse (py_return, format, (char *) ret_value);
break;
}
- default:
- {}
}
Py_DECREF (py_return);
if (success)
Modified: lldb/trunk/source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.cpp?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.cpp (original)
+++ lldb/trunk/source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.cpp Fri Dec
+++ 7 14:51:09 2012
@@ -453,7 +453,6 @@
switch (scalar.GetType())
{
case Scalar::e_void:
- default:
return false;
case Scalar::e_sint:
case Scalar::e_uint:
Modified: lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp (original)
+++ lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderD
+++ arwinKernel.cpp Fri Dec 7 14:51:09 2012
@@ -893,9 +893,6 @@
case eStateCrashed:
case eStateSuspended:
break;
-
- default:
- break;
}
}
Modified: lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp (original)
+++ lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMac
+++ OSXDYLD.cpp Fri Dec 7 14:51:09 2012
@@ -1605,9 +1605,6 @@
case eStateCrashed:
case eStateSuspended:
break;
-
- default:
- break;
}
}
Modified: lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp (original)
+++ lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp Fri
+++ Dec 7 14:51:09 2012
@@ -125,10 +125,6 @@
#define ENTRY_NAME(_type) _type: name = #_type
switch (type)
{
- default:
- name = "unkown";
- break;
-
case ENTRY_NAME(AT_NULL); break;
case ENTRY_NAME(AT_IGNORE); break;
case ENTRY_NAME(AT_EXECFD); break;
Modified: lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp (original)
+++ lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp
+++ Fri Dec 7 14:51:09 2012
@@ -13001,7 +13001,6 @@
{
switch (m_opcode_mode)
{
- default:
case eModeInvalid:
break;
Modified: lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.h?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.h (original)
+++ lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.h
+++ Fri Dec 7 14:51:09 2012
@@ -89,9 +89,6 @@
case eInstructionTypeAll:
return false;
-
- default:
- break;
}
return false;
}
Modified: lldb/trunk/source/Plugins/Process/POSIX/ProcessMessage.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/POSIX/ProcessMessage.cpp?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/POSIX/ProcessMessage.cpp (original)
+++ lldb/trunk/source/Plugins/Process/POSIX/ProcessMessage.cpp Fri Dec
+++ 7 14:51:09 2012
@@ -102,10 +102,6 @@
switch (reason)
{
- default:
- assert(false && "invalid CrashReason");
- break;
-
case eInvalidCrashReason:
str = "eInvalidCrashReason";
break;
@@ -204,10 +200,6 @@
switch (kind)
{
- default:
- assert(false && "invalid Kind");
- break;
-
case eInvalidMessage:
str = "eInvalidMessage";
break;
Modified: lldb/trunk/source/Plugins/Process/POSIX/ProcessPOSIX.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/POSIX/ProcessPOSIX.cpp?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/POSIX/ProcessPOSIX.cpp (original)
+++ lldb/trunk/source/Plugins/Process/POSIX/ProcessPOSIX.cpp Fri Dec 7
+++ 14:51:09 2012
@@ -322,10 +322,6 @@
switch (message.GetKind())
{
- default:
- assert(false && "Unexpected process message!");
- break;
-
case ProcessMessage::eInvalidMessage:
return;
Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationC
+++ lient.cpp Fri Dec 7 14:51:09 2012
@@ -1987,7 +1987,6 @@
case eWatchpointWrite: if (!m_supports_z2) return UINT8_MAX; break;
case eWatchpointRead: if (!m_supports_z3) return UINT8_MAX; break;
case eWatchpointReadWrite: if (!m_supports_z4) return UINT8_MAX; break;
- default: return UINT8_MAX;
}
char packet[64];
@@ -2017,7 +2016,6 @@
case eWatchpointWrite: m_supports_z2 = false; break;
case eWatchpointRead: m_supports_z3 = false; break;
case eWatchpointReadWrite: m_supports_z4 = false; break;
- default: break;
}
}
Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationC
+++ lient.h Fri Dec 7 14:51:09 2012
@@ -307,7 +307,6 @@
case eWatchpointWrite: return m_supports_z2;
case eWatchpointRead: return m_supports_z3;
case eWatchpointReadWrite: return m_supports_z4;
- default: break;
}
return false;
}
Modified: lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp (original)
+++ lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssembl
+++ yInstEmulation.cpp Fri Dec 7 14:51:09 2012
@@ -594,7 +594,6 @@
switch (context.type)
{
- default:
case EmulateInstruction::eContextInvalid:
case EmulateInstruction::eContextReadOpcode:
case EmulateInstruction::eContextImmediate:
Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/ClangASTContext.cpp?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/source/Symbol/ClangASTContext.cpp (original)
+++ lldb/trunk/source/Symbol/ClangASTContext.cpp Fri Dec 7 14:51:09
+++ 2012
@@ -194,7 +194,6 @@
{
switch (access)
{
- default: break;
case eAccessNone: return ObjCIvarDecl::None;
case eAccessPublic: return ObjCIvarDecl::Public;
case eAccessPrivate: return ObjCIvarDecl::Private;
@@ -708,8 +707,6 @@
if (bit_size && !(bit_size & 0x7u))
return ast->getExtVectorType (ast->UnsignedCharTy, bit_size/8).getAsOpaquePtr();
break;
- default:
- break;
}
return NULL;
Modified: lldb/trunk/source/Target/Process.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/Process.cpp?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/source/Target/Process.cpp (original)
+++ lldb/trunk/source/Target/Process.cpp Fri Dec 7 14:51:09 2012
@@ -671,10 +671,6 @@
file_actions, info->m_fd, info->m_path.c_str(), oflag, mode);
}
break;
-
- default:
- error.SetErrorStringWithFormat ("invalid file action: %i", info->m_action);
- break;
}
return error.Success();
}
@@ -3369,7 +3365,6 @@
// This is a transition from stop to run.
switch (m_thread_list.ShouldReportRun (event_ptr))
{
- default:
case eVoteYes:
case eVoteNoOpinion:
return_value = true;
Modified: lldb/trunk/source/lldb.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/lldb.cpp?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/source/lldb.cpp (original)
+++ lldb/trunk/source/lldb.cpp Fri Dec 7 14:51:09 2012
@@ -249,8 +249,6 @@
case eVoteNo: return "no";
case eVoteNoOpinion: return "no opinion";
case eVoteYes: return "yes";
- default:
- break;
}
return "invalid";
}
@@ -327,9 +325,6 @@
return regex.Execute (name);
}
break;
- default:
- assert (!"unhandled NameMatchType in lldb_private::NameMatches()");
- break;
}
}
return false;
Modified: lldb/trunk/tools/driver/Driver.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/driver/Driver.cpp?rev=169633&r1=169632&r2=169633&view=diff
==============================================================================
--- lldb/trunk/tools/driver/Driver.cpp (original)
+++ lldb/trunk/tools/driver/Driver.cpp Fri Dec 7 14:51:09 2012
@@ -796,7 +796,6 @@
StopReason thread_stop_reason = thread.GetStopReason();
switch (thread_stop_reason)
{
- default:
case eStopReasonInvalid:
case eStopReasonNone:
break;
_______________________________________________
lldb-commits mailing list
lldb-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
More information about the lldb-commits
mailing list