[Lldb-commits] [lldb] r146471 - in /lldb/trunk/test/functionalities/expr-doesnt-deadlock: ./ Makefile TestExprDoesntBlock.py locking.c

[Jim Ingham]

Author: jingham
Date: Mon Dec 12 22:04:44 2011
New Revision: 146471

URL: http://llvm.org/viewvc/llvm-project?rev=146471&view=rev
Log:
Add a pthreads testcase to make sure the two-step of running and expression,
having the block, then timing out & letting all threads run actually works.

Added:
    lldb/trunk/test/functionalities/expr-doesnt-deadlock/
    lldb/trunk/test/functionalities/expr-doesnt-deadlock/Makefile
    lldb/trunk/test/functionalities/expr-doesnt-deadlock/TestExprDoesntBlock.py
    lldb/trunk/test/functionalities/expr-doesnt-deadlock/locking.c

Added: lldb/trunk/test/functionalities/expr-doesnt-deadlock/Makefile
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/expr-doesnt-deadlock/Makefile?rev=146471&view=auto
==============================================================================
--- lldb/trunk/test/functionalities/expr-doesnt-deadlock/Makefile (added)
+++ lldb/trunk/test/functionalities/expr-doesnt-deadlock/Makefile Mon Dec 12 22:04:44 2011
@@ -0,0 +1,5 @@
+LEVEL = ../../make
+
+C_SOURCES := locking.c
+
+include $(LEVEL)/Makefile.rules

Added: lldb/trunk/test/functionalities/expr-doesnt-deadlock/TestExprDoesntBlock.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/expr-doesnt-deadlock/TestExprDoesntBlock.py?rev=146471&view=auto
==============================================================================
--- lldb/trunk/test/functionalities/expr-doesnt-deadlock/TestExprDoesntBlock.py (added)
+++ lldb/trunk/test/functionalities/expr-doesnt-deadlock/TestExprDoesntBlock.py Mon Dec 12 22:04:44 2011
@@ -0,0 +1,66 @@
+"""
+Test that expr will time out and allow other threads to run if it blocks.
+"""
+
+import os, time
+import re
+import unittest2
+import lldb, lldbutil
+from lldbtest import *
+
+class ExprDoesntDeadlockTestCase(TestBase):
+
+    mydir = os.path.join("functionalities", "expr-doesnt-deadlock")
+
+    @unittest2.skipUnless(sys.platform.startswith("darwin"), "requires Darwin")
+    def test_with_dsym_and_run_command(self):
+        """Test that expr will time out and allow other threads to run if it blocks - with dsym."""
+        self.buildDsym()
+        self.expr_doesnt_deadlock()
+
+    def test_with_dwarf_and_run_command(self):
+        """Test that expr will time out and allow other threads to run if it blocks."""
+        self.buildDwarf()
+        self.expr_doesnt_deadlock()
+
+    def setUp(self):
+        # Call super's setUp().
+        TestBase.setUp(self)
+
+    def expr_doesnt_deadlock (self):
+        """Test that expr will time out and allow other threads to run if it blocks."""
+        exe = os.path.join(os.getcwd(), "a.out")
+
+        # Create a target by the debugger.
+        target = self.dbg.CreateTarget(exe)
+        self.assertTrue(target, VALID_TARGET)
+
+        # Now create a breakpoint at source line before call_me_to_get_lock gets called.
+
+        main_file_spec = lldb.SBFileSpec ("locking.c")
+        breakpoint = target.BreakpointCreateBySourceRegex('Break here', main_file_spec)
+        print "breakpoint:", breakpoint
+        self.assertTrue(breakpoint and
+                        breakpoint.GetNumLocations() == 1,
+                        VALID_BREAKPOINT)
+
+        # Now launch the process, and do not stop at entry point.
+        process = target.LaunchSimple(None, None, os.getcwd())
+        self.assertTrue(process, PROCESS_IS_VALID)
+
+        # Frame #0 should be on self.line1 and the break condition should hold.
+        from lldbutil import get_stopped_thread
+        thread = get_stopped_thread(process, lldb.eStopReasonBreakpoint)
+        self.assertTrue(thread != None, "There should be a thread stopped due to breakpoint condition")
+
+        frame0 = thread.GetFrameAtIndex(0)
+
+        var = frame0.EvaluateExpression ("call_me_to_get_lock()")
+        self.assertTrue (var.IsValid())
+        self.assertTrue (var.GetValueAsSigned (0) == 567)
+        
+if __name__ == '__main__':
+    import atexit
+    lldb.SBDebugger.Initialize()
+    atexit.register(lambda: lldb.SBDebugger.Terminate())
+    unittest2.main()

Added: lldb/trunk/test/functionalities/expr-doesnt-deadlock/locking.c
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/expr-doesnt-deadlock/locking.c?rev=146471&view=auto
==============================================================================
--- lldb/trunk/test/functionalities/expr-doesnt-deadlock/locking.c (added)
+++ lldb/trunk/test/functionalities/expr-doesnt-deadlock/locking.c Mon Dec 12 22:04:44 2011
@@ -0,0 +1,80 @@
+#include <pthread.h>
+#include <stdlib.h>
+#include <unistd.h>
+#include <stdio.h>
+
+pthread_mutex_t contended_mutex = PTHREAD_MUTEX_INITIALIZER;
+
+pthread_mutex_t control_mutex = PTHREAD_MUTEX_INITIALIZER;
+pthread_cond_t  control_condition;
+
+pthread_mutex_t thread_started_mutex = PTHREAD_MUTEX_INITIALIZER;
+pthread_cond_t  thread_started_condition;
+
+// This function runs in a thread.  The locking dance is to make sure that 
+// by the time the main thread reaches the pthread_join below, this thread
+// has for sure acquired the contended_mutex.  So then the call_me_to_get_lock
+// function will block trying to get the mutex, and only succeed once it
+// signals this thread, then lets it run to wake up from the cond_wait and
+// release the mutex.
+
+void *
+lock_acquirer_1 (void *input)
+{
+  pthread_mutex_lock (&contended_mutex);
+  
+  // Grab this mutex, that will ensure that the main thread
+  // is in its cond_wait for it (since that's when it drops the mutex.
+
+  pthread_mutex_lock (&thread_started_mutex);
+  pthread_mutex_unlock(&thread_started_mutex);
+
+  // Now signal the main thread that it can continue, we have the contended lock
+  // so the call to call_me_to_get_lock won't make any progress till  this
+  // thread gets a chance to run.
+
+  pthread_mutex_lock (&control_mutex);
+
+  pthread_cond_signal (&thread_started_condition);
+
+  pthread_cond_wait (&control_condition, &control_mutex);
+
+  pthread_mutex_unlock (&contended_mutex);
+  return NULL;
+}
+
+int
+call_me_to_get_lock ()
+{
+  pthread_cond_signal (&control_condition);
+  pthread_mutex_lock (&contended_mutex);
+  return 567;
+}
+
+int main ()
+{
+  pthread_t thread_1;
+
+  pthread_cond_init (&control_condition, NULL);
+  pthread_cond_init (&thread_started_condition, NULL);
+
+  pthread_mutex_lock (&thread_started_mutex);
+
+  pthread_create (&thread_1, NULL, lock_acquirer_1, NULL);
+  
+  pthread_cond_wait (&thread_started_condition, &thread_started_mutex);
+
+  pthread_mutex_lock (&control_mutex);
+  pthread_mutex_unlock (&control_mutex);
+
+  // Break here.  At this point the other thread will have the contended_mutex,
+  // and be sitting in its cond_wait for the control condition.  So there is
+  // no way that our by-hand calling of call_me_to_get_lock will proceed
+  // without running the first thread at least somewhat.
+
+  call_me_to_get_lock();
+  pthread_join (thread_1, NULL);
+
+  return 0;
+
+}