[libcxx-commits] [libcxx] [libc++] Disables -Wweak-vtables diagnostics. (PR #85577)

[Nikolas Klauser via libcxx-commits]

================
@@ -27,6 +27,8 @@ _LIBCPP_BEGIN_NAMESPACE_STD
 template <class _Err>
 class bad_expected_access;
 
+_LIBCPP_DIAGNOSTIC_PUSH
+_LIBCPP_CLANG_DIAGNOSTIC_IGNORED("-Wweak-vtables")
----------------
philnik777 wrote:

There is only a difference for special member functions, since there are multiple sometimes. I don't know why clang decides to call the complete object destructor instead of the base object destructor when adding `[[gnu::weak]]` (maybe because it's considered replaceable with `[[gnu::weak]]`), but I don't think that's relevant. The fact that they are weak symbols without `[[gnu::weak]]` doesn't change.

What exactly did you try to add a definition to the dylib?

https://github.com/llvm/llvm-project/pull/85577