[libcxx-commits] [libcxx] [libc++] Disables -Wweak-vtables diagnostics. (PR #85577)

[Mark de Wever via libcxx-commits]

================
@@ -27,6 +27,8 @@ _LIBCPP_BEGIN_NAMESPACE_STD
 template <class _Err>
 class bad_expected_access;
 
+_LIBCPP_DIAGNOSTIC_PUSH
+_LIBCPP_CLANG_DIAGNOSTIC_IGNORED("-Wweak-vtables")
----------------
mordante wrote:

In the header I removed `_LIBCPP_HIDE_FROM_ABI_VIRTUAL` and changed `= default` to `{}`, I also tried with `_LIBCPP_OVERRIDABLE_FUNC_VIS` and `_LIBCPP_WEAK` in the dylib I tried with and without `_LIBCPP_WEAK`. And all permutations of this; but clang dislikes the re-declaration.

https://github.com/llvm/llvm-project/pull/85577