[libcxx-commits] [libcxx] [libc++] Disables -Wweak-vtables diagnostics. (PR #85577)

[Mark de Wever via libcxx-commits]

================
@@ -27,6 +27,8 @@ _LIBCPP_BEGIN_NAMESPACE_STD
 template <class _Err>
 class bad_expected_access;
 
+_LIBCPP_DIAGNOSTIC_PUSH
+_LIBCPP_CLANG_DIAGNOSTIC_IGNORED("-Wweak-vtables")
----------------
mordante wrote:

This is true for inline non-member functions. However for member functions there is a difference
https://godbolt.org/z/hP9rzfE5o.

I did test with it, but when I put a definition in the header I can't put a second definition in the dylib. Do you have a suggestion how to do this without an ABI break?

https://github.com/llvm/llvm-project/pull/85577